Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LABEL in could be any string #3424

Merged
merged 2 commits into from
Dec 13, 2021
Merged

LABEL in could be any string #3424

merged 2 commits into from
Dec 13, 2021

Conversation

liwenhui-soul
Copy link
Contributor

@liwenhui-soul liwenhui-soul commented Dec 7, 2021 •
edited
Loading

normally, string like "zone127.0.0.1_111" is illegal for name_label, this pr is to make these illegal strings in `` could be legal for name_label.

@liwenhui-soul liwenhui-soul added the ready-for-testing PR: ready for the CI test label Dec 7, 2021
@liwenhui-soul liwenhui-soul force-pushed the lwh branch 2 times, most recently from 4255112 to bf204c3 Compare December 7, 2021 10:56
@czpmango
Copy link
Contributor

czpmango commented Dec 8, 2021

Please add some test cases.

@darionyaphet
Copy link
Contributor

darionyaphet commented Dec 8, 2021 •
edited
Loading

SO, this PR can replace name_label with STRING?

@liwenhui-soul
Copy link
Contributor Author

liwenhui-soul commented Dec 8, 2021 •
edited
Loading

SO, this PR can replace name_label with STRING?

replace STRING with name_label

@liwenhui-soul
Copy link
Contributor Author

Please add some test cases.

done

@liwenhui-soul liwenhui-soul mentioned this pull request Dec 10, 2021
Merged
7 tasks
critical27
critical27 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@critical27 critical27 merged commit 1c2e1aa into vesoft-inc:master Dec 13, 2021
@yixinglu yixinglu added the doc affected PR: improvements or additions to documentation label Dec 13, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Dec 18, 2021
Closed
@liwenhui-soul liwenhui-soul mentioned this pull request Jan 21, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czpmango czpmango czpmango approved these changes

@critical27 critical27 critical27 approved these changes

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@cangfengzhs cangfengzhs Awaiting requested review from cangfengzhs

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

@yixinglu yixinglu Awaiting requested review from yixinglu

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liwenhui-soul @czpmango @darionyaphet @critical27 @yixinglu