Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small optimization to avoid recompilation #3398

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Dec 2, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Move the header-file-include to optimize compilation dependencies.

Which issue(s)/PR(s) this PR relates to?

Additional context:

Maybe we could do same things for other header files, especially Base.h,xxxUtil.h,etc.

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

No need to change.

@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Dec 2, 2021
@yixinglu yixinglu merged commit 43e4585 into vesoft-inc:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants