support s2 index params #3396
Merged
support s2 index params #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
added
the
incompatible
jievince
force-pushed
the
s2-index-params
branch
4 times, most recently
from
de49438 to
ae485d5
Compare
jievince
added
ready-for-testing
jievince
force-pushed
the
s2-index-params
branch
2 times, most recently
from
1944639 to
064ed80
Compare
jievince
force-pushed
the
s2-index-params
branch
4 times, most recently
from
e0dab64 to
bc06761
Compare
Codecov Report
@@ Coverage Diff @@
## master #3396 +/- ##
==========================================
- Coverage 85.19% 85.18% -0.02%
==========================================
Files 1306 1307 +1
Lines 122158 122550 +392
==========================================
+ Hits 104078 104397 +319
- Misses 18080 18153 +73
Continue to review full report at Codecov.
|
yixinglu
reviewed
Dec 10, 2021
src/parser/parser.yy
Outdated
| ; | ||
|
|
||
| index_param_item | ||
| : comment_prop_assignment { |
There was a problem hiding this comment.
comment_prop is better than comment_prop_assignment, refer to https://dev.mysql.com/doc/refman/8.0/en/create-index.html
There was a problem hiding this comment.
@Shylock-Hg WDYT ?
There was a problem hiding this comment.
It'ok. But better to modify it in independent PR.
Shylock-Hg
reviewed
Dec 16, 2021
jievince
added
the
incompatible
jievince
requested review from
yixinglu and
Shylock-Hg
and removed request for
Shylock-Hg
yixinglu
reviewed
Dec 21, 2021
jievince
force-pushed
the
s2-index-params
branch
from
db39393 to
45a3d10
Compare
jievince
force-pushed
the
s2-index-params
branch
8 times, most recently
from
4f53ea7 to
267f874
Compare
Shylock-Hg
reviewed
Dec 22, 2021
czpmango
reviewed
Dec 22, 2021
jievince
force-pushed
the
s2-index-params
branch
from
267f874 to
33b029b
Compare
czpmango
approved these changes
Dec 22, 2021
yixinglu
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Support the syntax like:
Which issue(s)/PR(s) this PR relates to?
close #3197
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: `