support cypher parameter(variable) #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
added
do not review
czpmango
force-pushed
the
varParam
branch
3 times, most recently
from
b580610 to
7108b62
Compare
Shylock-Hg
reviewed
Dec 3, 2021
czpmango
force-pushed
the
varParam
branch
5 times, most recently
from
37fcf81 to
5a2f6ad
Compare
czpmango
removed
do not review
czpmango
force-pushed
the
varParam
branch
2 times, most recently
from
36b147f to
5a7bb86
Compare
czpmango
force-pushed
the
varParam
branch
2 times, most recently
from
4c6ddb3 to
0090632
Compare
jievince
reviewed
Dec 13, 2021
Comment on lines
+117
to
+120
| folly::Future<ExecutionResponse> GraphService::future_executeWithParameter( | ||
| int64_t sessionId, | ||
| const std::string& query, | ||
| const std::unordered_map<std::string, Value>& parameterMap) { |
There was a problem hiding this comment.
Could we unify future_executeWithParameter and future_execute? They share almost the same code.
There was a problem hiding this comment.
After nebula-python's pr been merged.
czpmango
force-pushed
the
varParam
branch
3 times, most recently
from
8412d5c to
8edc63d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3379 +/- ##
==========================================
- Coverage 85.19% 85.19% -0.01%
==========================================
Files 1306 1307 +1
Lines 122158 122238 +80
==========================================
+ Hits 104078 104139 +61
- Misses 18080 18099 +19
Continue to review full report at Codecov.
|
CPWstatic
reviewed
Dec 17, 2021
CPWstatic
approved these changes
Dec 20, 2021
jievince
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Support cypher parameter with ngql variable.
Which issue(s)/PR(s) this PR relates to?
#2593
Checklist：
Release notes：
Support for parameterized statement must be added to the release notes.