Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload diskPaths for meta #3369

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

Nivras
Copy link
Contributor

@Nivras Nivras commented Nov 26, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

storage use heartbeat to send parititon's disk path info to meta.
key: disk_paths + spaceID + HostAddr + Path
value: set

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2021

CLA assistant check
All committers have signed the CLA.

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Nov 26, 2021
@darionyaphet
Copy link
Contributor

please fix test case failed thanks~

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

src/meta/processors/admin/HBProcessor.cpp Outdated Show resolved Hide resolved
src/clients/meta/MetaClient.cpp Outdated Show resolved Hide resolved
src/kvstore/DiskManager.cpp Show resolved Hide resolved
@Nivras Nivras force-pushed the update_disk_partition_info branch from 5940e55 to 044c7e9 Compare November 29, 2021 08:14
@Nivras Nivras force-pushed the update_disk_partition_info branch 3 times, most recently from 121e4d7 to bca42ae Compare November 30, 2021 08:54
@codecov-commenter
Copy link

Codecov Report

Merging #3369 (cd686e6) into master (6541438) will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3369      +/-   ##
==========================================
- Coverage   85.31%   85.24%   -0.07%     
==========================================
  Files        1289     1276      -13     
  Lines      120073   119068    -1005     
==========================================
- Hits       102442   101502     -940     
+ Misses      17631    17566      -65     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/kvstore/NebulaStore.h 95.23% <ø> (ø)
src/kvstore/PartManager.h 97.14% <ø> (ø)
src/meta/processors/job/JobManager.cpp 67.47% <33.33%> (-0.23%) ⬇️
src/graph/visitor/RewriteVisitor.cpp 76.37% <50.00%> (ø)
src/common/utils/MetaKeyUtils.cpp 81.02% <74.19%> (-0.30%) ⬇️
src/kvstore/PartManager.cpp 55.26% <80.00%> (+1.13%) ⬆️
src/clients/meta/MetaClient.cpp 76.00% <100.00%> (-0.53%) ⬇️
src/graph/validator/GroupByValidator.cpp 95.28% <100.00%> (ø)
src/graph/validator/MatchValidator.cpp 85.32% <100.00%> (ø)
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683f773...cd686e6. Read the comment docs.

@Nivras Nivras force-pushed the update_disk_partition_info branch from cd686e6 to bdccbf7 Compare December 1, 2021 02:21
@pengweisong pengweisong self-requested a review December 1, 2021 03:54
Copy link
Contributor

@pengweisong pengweisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

src/common/utils/MetaKeyUtils.cpp Outdated Show resolved Hide resolved
src/kvstore/DiskManager.cpp Outdated Show resolved Hide resolved
src/kvstore/DiskManager.cpp Outdated Show resolved Hide resolved
src/clients/meta/MetaClient.cpp Show resolved Hide resolved
src/common/utils/MetaKeyUtils.cpp Outdated Show resolved Hide resolved
src/kvstore/DiskManager.cpp Show resolved Hide resolved
src/kvstore/DiskManager.h Outdated Show resolved Hide resolved
src/kvstore/PartManager.h Outdated Show resolved Hide resolved
src/meta/processors/admin/HBProcessor.cpp Show resolved Hide resolved
@Nivras Nivras force-pushed the update_disk_partition_info branch from ca00e75 to b5f59c3 Compare December 1, 2021 05:34
@Nivras Nivras requested a review from pengweisong December 1, 2021 06:18
pengweisong
pengweisong previously approved these changes Dec 1, 2021
@Nivras Nivras requested a review from darionyaphet December 1, 2021 06:31
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@critical27 critical27 merged commit 8903faa into vesoft-inc:master Dec 1, 2021
@Nivras Nivras mentioned this pull request Dec 6, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants