-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload diskPaths for meta #3369
Upload diskPaths for meta #3369
Conversation
please fix test case failed thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
5940e55
to
044c7e9
Compare
121e4d7
to
bca42ae
Compare
Codecov Report
@@ Coverage Diff @@
## master #3369 +/- ##
==========================================
- Coverage 85.31% 85.24% -0.07%
==========================================
Files 1289 1276 -13
Lines 120073 119068 -1005
==========================================
- Hits 102442 101502 -940
+ Misses 17631 17566 -65
Continue to review full report at Codecov.
|
cd686e6
to
bdccbf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
ca00e75
to
b5f59c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
What type of PR is this?
What does this PR do?
storage use heartbeat to send parititon's disk path info to meta.
key: disk_paths + spaceID + HostAddr + Path
value: set
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: