Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - tck contains is invalid #3314

Merged
merged 9 commits into from
Nov 26, 2021

Conversation

heroicNeZha
Copy link
Contributor

@heroicNeZha heroicNeZha commented Nov 15, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

fix bug : tck contains is invalid
When executing query:
"""
SHOW USERS
"""
Then the result should contain:
| Account |
| "xxxxx" |
get passed

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2021

CLA assistant check
All committers have signed the CLA.

@Aiee
Copy link
Contributor

Aiee commented Nov 15, 2021

Please add some test cases.

@heroicNeZha heroicNeZha reopened this Nov 15, 2021
@jievince
Copy link
Contributor

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign the CLA first

jievince
jievince previously approved these changes Nov 15, 2021
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jievince jievince added the ready-for-testing PR: ready for the CI test label Nov 15, 2021
CPWstatic
CPWstatic previously approved these changes Nov 15, 2021
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Nov 19, 2021
@heroicNeZha heroicNeZha dismissed stale reviews from CPWstatic and jievince via 224e229 November 19, 2021 07:53
jievince
jievince previously approved these changes Nov 20, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use following commands to restore the unnecessary changes:

$ git reset HEAD~6
# restore changes
$ git commit -am '.....'

tests/tck/features/index/TagEdgeIndex.feature Outdated Show resolved Hide resolved
tests/tck/features/index/TagEdgeIndex.feature Outdated Show resolved Hide resolved
tests/tck/features/admin/Hosts.feature Outdated Show resolved Hide resolved
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@yixinglu yixinglu merged commit 53c3c2f into vesoft-inc:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants