Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Edit cmakelist to void conflict with nebula ent #3307

Merged
merged 5 commits into from
Nov 15, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Nov 11, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Edit cmakelist to void conflict with nebula ent (https://github.com/vesoft-inc/nebula-ent/pull/232/files)

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@Aiee Aiee added the ready-for-testing PR: ready for the CI test label Nov 11, 2021
@Aiee Aiee requested review from Shylock-Hg and jievince November 11, 2021 09:15
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Nov 12, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3307 (b6b159f) into master (28776ae) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3307      +/-   ##
==========================================
- Coverage   85.36%   85.29%   -0.07%     
==========================================
  Files        1305     1305              
  Lines      120433   120445      +12     
==========================================
- Hits       102805   102731      -74     
- Misses      17628    17714      +86     
Impacted Files Coverage Δ
src/parser/test/ScannerTest.cpp 98.27% <100.00%> (ø)
src/kvstore/raftex/Host.cpp 65.41% <0.00%> (-8.36%) ⬇️
src/kvstore/raftex/RaftPart.cpp 75.00% <0.00%> (-2.64%) ⬇️
src/graph/executor/StorageAccessExecutor.h 66.66% <0.00%> (-2.57%) ⬇️
src/parser/GraphScanner.h 91.46% <0.00%> (-2.29%) ⬇️
src/common/base/Status.h 88.63% <0.00%> (-2.28%) ⬇️
src/meta/processors/parts/ListHostsProcessor.cpp 72.13% <0.00%> (-2.00%) ⬇️
src/graph/service/PermissionCheck.cpp 78.72% <0.00%> (-1.72%) ⬇️
src/kvstore/Part.cpp 56.69% <0.00%> (-1.19%) ⬇️
src/common/meta/ServerBasedSchemaManager.cpp 81.25% <0.00%> (-1.05%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289aadb...b6b159f. Read the comment docs.

@yixinglu yixinglu merged commit fc2977b into vesoft-inc:master Nov 15, 2021
@Aiee Aiee deleted the cmakelist branch March 15, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants