Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel memory check when the ratio greater than 1.0 #3289

Merged
merged 6 commits into from
Nov 15, 2021

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Nov 9, 2021

Provide a way to cancel memory checking to avoid the case which the memory info files don't exist in some OS.

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Nov 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #3289 (e99ce9f) into master (8e0028f) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3289      +/-   ##
==========================================
- Coverage   85.29%   85.26%   -0.03%     
==========================================
  Files        1305     1305              
  Lines      120383   120391       +8     
==========================================
- Hits       102683   102655      -28     
- Misses      17700    17736      +36     
Impacted Files Coverage Δ
src/common/memory/MemoryUtils.cpp 92.68% <50.00%> (-2.19%) ⬇️
...torage/transaction/ChainAddEdgesProcessorLocal.cpp 58.82% <50.00%> (+0.01%) ⬆️
src/graph/executor/StorageAccessExecutor.h 66.66% <0.00%> (-8.98%) ⬇️
src/common/thread/GenericWorker.h 92.30% <0.00%> (-3.85%) ⬇️
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <0.00%> (-2.54%) ⬇️
src/common/base/Status.h 88.63% <0.00%> (-2.28%) ⬇️
src/common/expression/UnaryExpression.cpp 78.88% <0.00%> (-2.23%) ⬇️
src/common/meta/ServerBasedSchemaManager.cpp 81.25% <0.00%> (-1.91%) ⬇️
src/storage/exec/QueryUtils.h 91.42% <0.00%> (-1.78%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 57.66% <0.00%> (-1.67%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1d720...e99ce9f. Read the comment docs.

@yixinglu yixinglu merged commit be4d5bb into vesoft-inc:master Nov 15, 2021
@yixinglu yixinglu deleted the no-check-memory branch November 15, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants