Modify index bound value #3285
Merged
Modify index bound value #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cangfengzhs
requested review from
yixinglu,
critical27,
czpmango and
bright-starry-sky
czpmango
reviewed
Nov 9, 2021
czpmango
reviewed
Nov 9, 2021
Comment on lines
+261
to
+264
| } else { | ||
| auto tmp = std::make_pair(item.value_, include); | ||
| OptimizerUtils::compareAndSwapBound(end, tmp); | ||
| } |
There was a problem hiding this comment.
assign min(end,tmp) to end
czpmango
reviewed
Nov 9, 2021
cangfengzhs
force-pushed
the
modify-index-bound-value
branch
from
1159341 to
c6eb158
Compare
Codecov Report
@@ Coverage Diff @@
## master #3285 +/- ##
==========================================
+ Coverage 85.24% 85.30% +0.06%
==========================================
Files 1295 1303 +8
Lines 118190 119417 +1227
==========================================
+ Hits 100748 101873 +1125
- Misses 17442 17544 +102
Continue to review full report at Codecov.
|
critical27
reviewed
Nov 11, 2021
| h.hint.set_begin_value(std::move(begin)); | ||
| h.score = IndexScore::kPrefix; | ||
| } else if (begin.first == end.first) { | ||
| if (begin.second == false && end.second == false) { |
There was a problem hiding this comment.
Why we don't need to return false for case (x, x], [x, x)?
(x, x) has return false in line 244
There was a problem hiding this comment.
This is a good suggestion. I was not sure if (x,x] or [x,x) represented the empty set.
critical27
approved these changes
Nov 16, 2021
czpmango
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
close issue 2745
Which issue(s)/PR(s) this PR relates to?
Fix the problem of index query interval error
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: