Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable yield var #3271

Merged
merged 19 commits into from
Nov 24, 2021
Merged

disable yield var #3271

merged 19 commits into from
Nov 24, 2021

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Nov 4, 2021

Fixes #2960
fixes #3211

@Shylock-Hg Shylock-Hg added the incompatible PR: incompatible with the recently released version label Nov 4, 2021
@Shylock-Hg Shylock-Hg added the doc affected PR: improvements or additions to documentation label Nov 4, 2021
@czpmango czpmango force-pushed the disable-yield-var branch 2 times, most recently from 1d790e8 to e7ffdea Compare November 4, 2021 06:56
@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Nov 4, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #3271 (0112069) into master (6541438) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3271      +/-   ##
==========================================
- Coverage   85.31%   85.29%   -0.02%     
==========================================
  Files        1289     1289              
  Lines      120073   120079       +6     
==========================================
- Hits       102442   102425      -17     
- Misses      17631    17654      +23     
Impacted Files Coverage Δ
src/graph/optimizer/rule/TopNRule.cpp 95.83% <ø> (ø)
src/graph/util/ExpressionUtils.h 100.00% <ø> (ø)
src/graph/visitor/RewriteVisitor.cpp 76.37% <50.00%> (ø)
src/graph/util/ExpressionUtils.cpp 92.38% <100.00%> (+0.07%) ⬆️
src/graph/validator/GroupByValidator.cpp 95.28% <100.00%> (ø)
src/graph/validator/MatchValidator.cpp 85.32% <100.00%> (ø)
...eta/processors/session/SessionManagerProcessor.cpp 74.19% <0.00%> (-4.52%) ⬇️
src/common/datatypes/HostAddrOps-inl.h 75.67% <0.00%> (-2.71%) ⬇️
src/kvstore/Part.cpp 54.70% <0.00%> (-2.61%) ⬇️
src/common/base/Status.h 88.63% <0.00%> (-2.28%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c6901...0112069. Read the comment docs.

@Shylock-Hg
Copy link
Contributor

How about other clauses? For example variable in where?

@czpmango
Copy link
Contributor Author

How about other clauses? For example variable in where?

The other clause behavior remains as before.

CPWstatic
CPWstatic previously approved these changes Nov 18, 2021
jievince
jievince previously approved these changes Nov 19, 2021
darionyaphet
darionyaphet previously approved these changes Nov 22, 2021
src/parser/parser.yy Outdated Show resolved Hide resolved
@czpmango czpmango dismissed stale reviews from darionyaphet, jievince, and CPWstatic via 4d20ec8 November 23, 2021 09:33
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 65fdeed into vesoft-inc:master Nov 24, 2021
@foesa-yang foesa-yang removed the doc affected PR: improvements or additions to documentation label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngql Variable undefined behaviors in yield clause don't support YIELD var
9 participants