Feature/bison datetime parser #3179

Shylock-Hg · 2021-10-21T11:29:14Z

Refactor #2770 by bison.

…ature/bison-datetime-parser

codecov-commenter · 2021-10-21T13:42:59Z

Codecov Report

Merging #3179 (7a39eff) into master (67bb6ff) will increase coverage by 0.01%.
The diff coverage is 94.23%.

@@            Coverage Diff             @@
##           master    #3179      +/-   ##
==========================================
+ Coverage   85.32%   85.34%   +0.01%     
==========================================
  Files        1289     1293       +4     
  Lines      119819   120024     +205     
==========================================
+ Hits       102239   102430     +191     
- Misses      17580    17594      +14

Impacted Files	Coverage Δ
src/common/time/TimezoneInfo.cpp	`50.00% <ø> (+4.54%)`	⬆️
src/daemons/GraphDaemon.cpp	`65.51% <50.00%> (-0.56%)`	⬇️
src/daemons/MetaDaemon.cpp	`62.62% <50.00%> (-0.27%)`	⬇️
src/daemons/StorageDaemon.cpp	`62.22% <50.00%> (-0.57%)`	⬇️
src/common/datatypes/test/ValueToJsonTest.cpp	`88.19% <64.28%> (-0.56%)`	⬇️
src/common/time/TimeUtils.h	`84.00% <80.00%> (-4.58%)`	⬇️
src/common/time/parser/DatetimeReader.cpp	`97.22% <97.22%> (ø)`
src/common/time/parser/test/DateTimeParserTest.cpp	`99.19% <99.19%> (ø)`
src/common/datatypes/Date.cpp	`100.00% <100.00%> (ø)`
src/common/datatypes/Date.h	`72.82% <100.00%> (+3.69%)`	⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0fbb6...7a39eff. Read the comment docs.

src/common/time/parser/datetime_parser.yy

src/common/time/parser/test/CMakeLists.txt

src/common/time/parser/DatetimeScanner.h

yixinglu · 2021-10-27T03:29:48Z

src/common/time/parser/datetime_parser.yy

+  ;
+
+date
+  : INTEGER NEGATIVE INTEGER NEGATIVE INTEGER {


Why not use parser to validate the date value? It's more clear to replace the INTEGER with meaningful YEAR to validate the format. You can define the YEAR with regex {DEC}{1,4} to do the same thing.

We still need to check the value range, e.g. 99 is still invalid minute number. So do it in one place now.

minutes could also use regex to validate. you have used the parser why not let it do more thing?

It's too complicate.

And different month has different count of days, it can't validate by lex/parse rule.

minutes could also use regex to validate. you have used the parser why not let it do more thing?

Where is this check? I don't find it.

See validateDate function

…ature/bison-datetime-parser

HarrisChu · 2022-01-11T08:37:38Z

incompatible with before.
should info users that timestamp just means time in seconds

(root@nebula) [s1]> yield timestamp("2020-01-11T19:28:23")
+----------------------------------+
| timestamp("2020-01-11T19:28:23") |
+----------------------------------+
| 1578770903                       |
+----------------------------------+
Got 1 rows (time spent 3166/14662 us)

Tue, 11 Jan 2022 16:29:18 CST

(root@nebula) [s1]> yield timestamp("2020-01-11T19:28:23.123456")
+-----------------------------------------+
| timestamp("2020-01-11T19:28:23.123456") |
+-----------------------------------------+
| BAD_DATA                                |
+-----------------------------------------+
Got 1 rows (time spent 2434/14832 us)

Tue, 11 Jan 2022 16:29:28 CST

(root@nebula) [s1]> yield timestamp(1641890171222)
+--------------------------+
| timestamp(1641890171222) |
+--------------------------+
| BAD_DATA                 |
+--------------------------+
Got 1 rows (time spent 2637/13288 us)

Tue, 11 Jan 2022 16:36:51 CST

(root@nebula) [s1]> yield timestamp(1641890171)
+-----------------------+
| timestamp(1641890171) |
+-----------------------+
| 1641890171            |
+-----------------------+
Got 1 rows (time spent 2490/10609 us)

Tue, 11 Jan 2022 16:36:53 CST

Shylock-Hg · 2022-01-11T08:42:08Z

incompatible with before. should info users that timestamp just means time in seconds

(root@nebula) [s1]> yield timestamp("2020-01-11T19:28:23")
+----------------------------------+
| timestamp("2020-01-11T19:28:23") |
+----------------------------------+
| 1578770903                       |
+----------------------------------+
Got 1 rows (time spent 3166/14662 us)

Tue, 11 Jan 2022 16:29:18 CST

(root@nebula) [s1]> yield timestamp("2020-01-11T19:28:23.123456")
+-----------------------------------------+
| timestamp("2020-01-11T19:28:23.123456") |
+-----------------------------------------+
| BAD_DATA                                |
+-----------------------------------------+
Got 1 rows (time spent 2434/14832 us)

Tue, 11 Jan 2022 16:29:28 CST

(root@nebula) [s1]> yield timestamp(1641890171222)
+--------------------------+
| timestamp(1641890171222) |
+--------------------------+
| BAD_DATA                 |
+--------------------------+
Got 1 rows (time spent 2637/13288 us)

Tue, 11 Jan 2022 16:36:51 CST

(root@nebula) [s1]> yield timestamp(1641890171)
+-----------------------+
| timestamp(1641890171) |
+-----------------------+
| 1641890171            |
+-----------------------+
Got 1 rows (time spent 2490/10609 us)

Tue, 11 Jan 2022 16:36:53 CST

This PR don't modify this.

Shylock-Hg added 7 commits October 20, 2021 15:43

Implement datetime parser by bison.

1d36ecd

Remove unused code.

a76c8a2

Merge branch 'master' of https://github.com/vesoft-inc/nebula into fe…

d82f130

…ature/bison-datetime-parser

Add the time parser.

2cd7805

Fix case.

e09c809

Tune zone.

477ecd3

Merge branch 'master' of https://github.com/vesoft-inc/nebula into fe…

c927054

…ature/bison-datetime-parser

Shylock-Hg added ready-for-testing PR: ready for the CI test doc affected PR: improvements or additions to documentation labels Oct 21, 2021

Shylock-Hg requested review from yixinglu, nevermore3, CPWstatic, critical27, Aiee, cangfengzhs, czpmango and bright-starry-sky October 21, 2021 11:29

Shylock-Hg mentioned this pull request Oct 21, 2021

Add the time parser. #2770

Closed

jievince reviewed Oct 22, 2021

View reviewed changes

src/common/time/parser/datetime_parser.yy Outdated Show resolved Hide resolved

Merge branch 'master' into feature/bison-datetime-parser

864ff5e

Shylock-Hg requested a review from jievince October 22, 2021 02:13

jievince reviewed Oct 22, 2021

View reviewed changes

src/common/time/parser/datetime_parser.yy Outdated Show resolved Hide resolved

src/common/time/parser/test/CMakeLists.txt Show resolved Hide resolved

Shylock-Hg requested a review from jievince October 22, 2021 02:26

Shylock-Hg added 4 commits October 22, 2021 10:38

Remove debug code.

1af62b6

Fix leak.

2f15b7c

Merge branch 'master' into feature/bison-datetime-parser

1d3da50

Merge branch 'master' into feature/bison-datetime-parser

050e0a9

yixinglu reviewed Oct 27, 2021

View reviewed changes

Merge branch 'master' of https://github.com/vesoft-inc/nebula into fe…

7ee9a62

…ature/bison-datetime-parser

Merge branch 'master' into feature/bison-datetime-parser

40303be

jievince previously approved these changes Nov 24, 2021

View reviewed changes

Merge branch 'master' into feature/bison-datetime-parser

4f482b6

Aiee previously approved these changes Nov 25, 2021

View reviewed changes

Shylock-Hg added 3 commits November 26, 2021 16:46

Merge branch 'master' into feature/bison-datetime-parser

cb53a74

Merge branch 'master' into feature/bison-datetime-parser

c554df0

Resolve conflict.

29c40d3

Shylock-Hg dismissed stale reviews from Aiee and jievince via 29c40d3 November 30, 2021 03:00

Shylock-Hg requested review from Aiee and jievince November 30, 2021 03:01

Shylock-Hg added 3 commits December 2, 2021 11:25

Merge branch 'master' of https://github.com/vesoft-inc/nebula into fe…

2b5164d

…ature/bison-datetime-parser

Merge branch 'master' into feature/bison-datetime-parser

bcac0e0

Merge branch 'master' into feature/bison-datetime-parser

828cc3e

jievince approved these changes Dec 8, 2021

View reviewed changes

Merge branch 'master' into feature/bison-datetime-parser

7a39eff

Aiee approved these changes Dec 13, 2021

View reviewed changes

yixinglu added 3 commits December 13, 2021 14:33

Merge branch 'master' into feature/bison-datetime-parser

3991f39

Merge branch 'master' into feature/bison-datetime-parser

f1bae68

Merge branch 'master' into feature/bison-datetime-parser

34cb561

yixinglu merged commit 393e169 into vesoft-inc:master Dec 13, 2021

yixinglu mentioned this pull request Dec 14, 2021

Fix flex warning about default rule #3459

Closed

3 tasks

jamieliu1023 mentioned this pull request Dec 18, 2021

Weekly Report 2021-12-17 vesoft-inc/nebula-community#79

Closed

HarrisChu added the incompatible PR: incompatible with the recently released version label Jan 11, 2022

HarrisChu removed the incompatible PR: incompatible with the recently released version label Jan 11, 2022

HarrisChu mentioned this pull request Jan 24, 2022

metad is crashed after upgrade from v1 vesoft-inc/nebula-docs#1061

Closed

Shylock-Hg deleted the feature/bison-datetime-parser branch February 9, 2022 07:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/bison datetime parser #3179

Feature/bison datetime parser #3179

Shylock-Hg commented Oct 21, 2021 •

edited

Loading

codecov-commenter commented Oct 21, 2021 •

edited

Loading

yixinglu Oct 27, 2021

Shylock-Hg Oct 27, 2021 •

edited

Loading

yixinglu Oct 27, 2021

Shylock-Hg Oct 28, 2021

Shylock-Hg Oct 28, 2021

jievince Nov 18, 2021

Shylock-Hg Nov 18, 2021

HarrisChu commented Jan 11, 2022

Shylock-Hg commented Jan 11, 2022

Feature/bison datetime parser #3179

Feature/bison datetime parser #3179

Conversation

Shylock-Hg commented Oct 21, 2021 • edited Loading

codecov-commenter commented Oct 21, 2021 • edited Loading

Codecov Report

yixinglu Oct 27, 2021

Choose a reason for hiding this comment

Shylock-Hg Oct 27, 2021 • edited Loading

Choose a reason for hiding this comment

yixinglu Oct 27, 2021

Choose a reason for hiding this comment

Shylock-Hg Oct 28, 2021

Choose a reason for hiding this comment

Shylock-Hg Oct 28, 2021

Choose a reason for hiding this comment

jievince Nov 18, 2021

Choose a reason for hiding this comment

Shylock-Hg Nov 18, 2021

Choose a reason for hiding this comment

HarrisChu commented Jan 11, 2022

Shylock-Hg commented Jan 11, 2022

Shylock-Hg commented Oct 21, 2021 •

edited

Loading

codecov-commenter commented Oct 21, 2021 •

edited

Loading

Shylock-Hg Oct 27, 2021 •

edited

Loading