Support more validation when create space on an empty zone #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
requested review from
critical27,
liuyu85cn,
bright-starry-sky and
panda-sheep
Codecov Report
@@ Coverage Diff @@
## master #3065 +/- ##
==========================================
- Coverage 84.30% 84.25% -0.05%
==========================================
Files 1287 1287
Lines 115636 115678 +42
==========================================
- Hits 97483 97466 -17
- Misses 18153 18212 +59
Continue to review full report at Codecov.
|
yixinglu
reviewed
Oct 14, 2021
| @@ -315,8 +328,6 @@ StatusOr<Hosts> CreateSpaceProcessor::pickHostsWithZone( | |||
| } | |||
|
|
|||
| if (code != nebula::cpp2::ErrorCode::SUCCEEDED) { | |||
| handleErrorCode(code); | |||
| onFinished(); | |||
There was a problem hiding this comment.
Why to delete these error handle codes?
There was a problem hiding this comment.
Moved outside to unified processing
liuyu85cn
reviewed
Oct 15, 2021
darionyaphet
force-pushed
the
fix-3028
branch
from
a88b690 to
86e307b
Compare
liuyu85cn
approved these changes
Oct 18, 2021
yixinglu
approved these changes
Oct 18, 2021
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 18, 2021
Co-authored-by: Yee <[email protected]> Co-authored-by: Doodle <[email protected]>
CPWstatic
pushed a commit
that referenced
this pull request
Oct 19, 2021
* Pass graph profile param into storage and cleanup graph storage client interfaces (#3026) * Cleanup graph storage client interfaces * Fix compile * Format * Fix shadow compile error * Fix storage core when exit (#3050) * although I don't have time to check why it works, but this do fix the issue * fix ut * Accumulate toss bug fix during test. (#3091) * add some debug info * accumulate bug fix for TOSS Co-authored-by: Doodle <[email protected]> * Support more validation when create space on an empty zone (#3065) Co-authored-by: Yee <[email protected]> Co-authored-by: Doodle <[email protected]> * small tck fix (#3087) Co-authored-by: jie.wang <[email protected]> * cascading deletion and addition (#3059) Co-authored-by: Doodle <[email protected]> * fix toss switch not set properly (#3119) Co-authored-by: Yee <[email protected]> Co-authored-by: Doodle <[email protected]> Co-authored-by: Yee <[email protected]> Co-authored-by: Doodle <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: yaphet <[email protected]> Co-authored-by: kyle.cao <[email protected]> Co-authored-by: jie.wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.