Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Added some concurrent utilities, GenericThreadPool, etc. #3

Merged
merged 2 commits into from
Sep 5, 2018
Merged

[Feature] Added some concurrent utilities, GenericThreadPool, etc. #3

merged 2 commits into from
Sep 5, 2018

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Sep 4, 2018 •
edited
Loading

This PR adds several utilities such as GenericThreadPool, GenericWorker, Barrier, Latch, ThreadLocalPtr and some other convenience things.

sherman-the-tank
sherman-the-tank reviewed Sep 5, 2018
View reviewed changes
Copy link
Member

@sherman-the-tank sherman-the-tank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!!

CMakeLists.txt Show resolved Hide resolved
common/concurrent/CMakeLists.txt Outdated Show resolved Hide resolved
common/concurrent/sync/Barrier.h Outdated Show resolved Hide resolved
common/concurrent/sync/Barrier.h Outdated Show resolved Hide resolved
common/concurrent/sync/Barrier.cpp Outdated Show resolved Hide resolved
common/concurrent/thread/ThreadLocalPtr.h Outdated Show resolved Hide resolved
common/cpp/macros.h Outdated Show resolved Hide resolved
common/cpp/macros.h Outdated Show resolved Hide resolved
common/concurrent/thread/NamedThread.h Outdated Show resolved Hide resolved
common/concurrent/thread/NamedThread.cpp Outdated Show resolved Hide resolved
@dutor
Copy link
Contributor Author

dutor commented Sep 5, 2018

Addressed @sherman-the-tank 's comments.

sherman-the-tank
sherman-the-tank approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@sherman-the-tank sherman-the-tank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dutor dutor merged commit c0722dc into vesoft-inc:master Sep 5, 2018
@monadbobo monadbobo mentioned this pull request Jul 4, 2019
Closed
This was referenced Jul 11, 2019
Closed
Closed
This was referenced Jul 31, 2019
Closed
Closed
yixinglu referenced this pull request in yixinglu/nebula Feb 16, 2020
@dutor
[Feature] Added some concurrent utilities, GenericThreadPool, etc. (#3)
371d5a6 
* [Feature] Added some concurrent utilities, GenericThreadPool, etc.
@wadeliuyi wadeliuyi mentioned this pull request Apr 16, 2020
Closed
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dutor
[Feature] Added some concurrent utilities, GenericThreadPool, etc. (v…
92d917b 
…esoft-inc#3)

* [Feature] Added some concurrent utilities, GenericThreadPool, etc.
@zedzhu zedzhu mentioned this pull request Nov 8, 2021
Closed
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request May 10, 2022
@panda-sheep
DSS part2: support sign in drainer service and add listener sync and …
5094091 
…add drainer (vesoft-inc#3)

* support sign in drainer service and add listener sync add add drainer

ut pass

Add more UT

add listener sync host:port to space name

* rebase master

* improve code

* address critical27's comments
F-Guardian referenced this pull request in F-Guardian/nebula Oct 16, 2023
@zhaojunnana
Merge pull request #3 from F-Guardian/bzl-hparg
559b184 
stream execute test v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherman-the-tank sherman-the-tank sherman-the-tank approved these changes

Assignees

@dutor dutor

@sherman-the-tank sherman-the-tank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dutor @sherman-the-tank