[Raft] rollback related optimize #2903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
reviewed
Sep 23, 2021
| nebula::cpp2::ErrorCode::E_RPC_FAILURE); | ||
| context->resp.markFailure(); | ||
| }) | ||
| .ensure([context, host] { |
There was a problem hiding this comment.
Good improvement! It's what i want to do like this. Maybe we can do more for all requests by folly::collect
|
Generally LTGM. could you resolve the conflicts? |
Codecov Report
@@ Coverage Diff @@
## master #2903 +/- ##
==========================================
- Coverage 85.47% 84.71% -0.77%
==========================================
Files 1229 1231 +2
Lines 110375 110844 +469
==========================================
- Hits 94341 93897 -444
- Misses 16034 16947 +913
Continue to review full report at Codecov.
|
|
I will separate this PR into multiple parts, the problem is more than complicated than I expected. Timeout will open another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still doing some test, don't merge to 2.6.0 plz.