Improve memory watermark detection #2885
Conversation
yixinglu
force-pushed
the
mem-watermark
branch
3 times, most recently
from
4569886 to
2f225fd
Compare
yixinglu
force-pushed
the
mem-watermark
branch
4 times, most recently
from
fb00cee to
cb4b57e
Compare
yixinglu
added
ready-for-testing
yixinglu
force-pushed
the
mem-watermark
branch
from
cb4b57e to
7ad379d
Compare
yixinglu
force-pushed
the
mem-watermark
branch
from
135b321 to
1f32cee
Compare
|
cc @MegaByte875 Watermark would check |
yixinglu
force-pushed
the
mem-watermark
branch
from
1f32cee to
88e63f8
Compare
src/graph/service/QueryEngine.cpp
Outdated
| instance->execute(); | ||
| } | ||
|
|
||
| Status QueryEngine::setupBackgroundThread() { |
There was a problem hiding this comment.
We had many background thread now, better name it properly.
There was a problem hiding this comment.
Fixed. I think we could use the same thread to do the background task in the future.
| throw std::runtime_error( | ||
| folly::sformat("Used memory hits the high watermark({}) of total system memory.", | ||
| FLAGS_system_memory_high_watermark_ratio)); |
There was a problem hiding this comment.
Where is handler the runtime error?
There was a problem hiding this comment.
Where is handler the runtime error?
What's about as below ?
if (MemoryUtils::kHitMemoryHighWatermark.load()) {
LOG(ERROR);
return true;
}
There was a problem hiding this comment.
There is a thenError in QueryInstance
There was a problem hiding this comment.
There is a thenError in QueryInstance
got . LGTM now. Please resolved conflicts.
There was a problem hiding this comment.
Stop the query execution by throwing the exception rather than skip some rows.
yixinglu
force-pushed
the
mem-watermark
branch
from
88e63f8 to
08ec4e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #2885 +/- ##
==========================================
- Coverage 84.40% 84.30% -0.10%
==========================================
Files 1284 1283 -1
Lines 113608 113679 +71
==========================================
- Hits 95888 95839 -49
- Misses 17720 17840 +120
Continue to review full report at Codecov.
|
Sophie-Xie
added
doc affected
fix #2497 and fix #2591