Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: "show jobs" only show space related #2872

Merged
merged 7 commits into from
Sep 24, 2021
Merged

Enhancement: "show jobs" only show space related #2872

merged 7 commits into from
Sep 24, 2021

Conversation

SuperYoko
Copy link
Contributor

  • Show jobs will still remove all space expired jobs
  • You will need choose one spaces before show job(s)
  • You can not show other spaces's job

@CPWstatic
Copy link
Contributor

Please add some tests in tck/ directory.

panda-sheep
panda-sheep reviewed Sep 16, 2021
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job！

@SuperYoko SuperYoko linked an issue Sep 17, 2021 that may be closed by this pull request
[STO]optimize job: Show job by space; Control the privilege when using “show all”; #2815
Closed
@SuperYoko SuperYoko changed the title Enhancement: "show jobs" only show space related WIP:Enhancement: "show jobs" only show space related Sep 17, 2021
@SuperYoko SuperYoko added the wip Solution: work in progress label Sep 17, 2021
@SuperYoko SuperYoko changed the title WIP:Enhancement: "show jobs" only show space related Enhancement: "show jobs" only show space related Sep 18, 2021
@SuperYoko
Enhancement:change "show jobs" behavior to only print space related j…
474732a 
…obs.(#2815)

* show jobs will still remove all space expired jobs
* you will need choose one spaces before show job(s)
@SuperYoko
FixReview: handle "stop job"&"recover job"
ca3c3af 
* only can stop jobs in chosen space
* only recover jobs in chosen space
@SuperYoko SuperYoko removed the wip Solution: work in progress label Sep 22, 2021
yixinglu
yixinglu reviewed Sep 22, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

tests/tck/job/Job.feature Show resolved Hide resolved
@bright-starry-sky
Copy link
Contributor

Ready to review?

@panda-sheep panda-sheep added the ready-for-testing PR: ready for the CI test label Sep 23, 2021
critical27
critical27 reviewed Sep 23, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

src/graph/validator/AdminJobValidator.cpp Outdated Show resolved Hide resolved
tests/tck/job/Job.feature Show resolved Hide resolved
panda-sheep
panda-sheep approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@critical27
Copy link
Contributor

Well done

@yixinglu yixinglu merged commit 3941945 into vesoft-inc:master Sep 24, 2021
@yixinglu yixinglu added the doc affected PR: improvements or additions to documentation label Sep 24, 2021
@SuperYoko SuperYoko deleted the restrict_showjob_in_space branch September 24, 2021 15:39
This was referenced Oct 20, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu left review comments

@panda-sheep panda-sheep panda-sheep approved these changes

@critical27 critical27 critical27 approved these changes

@pengweisong pengweisong Awaiting requested review from pengweisong

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[STO]optimize job: Show job by space; Control the privilege when using “show all”;
6 participants
@SuperYoko @CPWstatic @bright-starry-sky @critical27 @yixinglu @panda-sheep