Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format fetchvertices #2572

Merged
merged 8 commits into from
Sep 24, 2021
Merged

format fetchvertices #2572

merged 8 commits into from
Sep 24, 2021

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Aug 25, 2021 •
edited
Loading

1、 change QueryUtil.h QuerytUtil.cpp to PlannerUtil.h PlannerUtil.cpp
2、 add ValidateUtil.h ValidateUtil.cpp
3、 refactor fetch vertices
4、 support YIELD vertex as name, id(vertex)

@nevermore3 nevermore3 added the wip Solution: work in progress label Aug 25, 2021
@nevermore3 nevermore3 force-pushed the format_fetchvertices branch 6 times, most recently from 041958d to 501b1f8 Compare August 30, 2021 08:53
@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels Aug 30, 2021
@nevermore3 nevermore3 force-pushed the format_fetchvertices branch 3 times, most recently from 3990d70 to d06741a Compare August 31, 2021 06:32
@nevermore3 nevermore3 requested a review from a team September 2, 2021 02:10
Shylock-Hg
Shylock-Hg reviewed Sep 2, 2021
View reviewed changes
src/parser/parser.yy Outdated Show resolved Hide resolved
@Shylock-Hg Shylock-Hg added the incompatible PR: incompatible with the recently released version label Sep 6, 2021
@nevermore3 nevermore3 removed ready-for-testing PR: ready for the CI test incompatible PR: incompatible with the recently released version labels Sep 15, 2021
@nevermore3
Copy link
Contributor Author

subjob of #2594

@nevermore3 nevermore3 force-pushed the format_fetchvertices branch 5 times, most recently from 02490a3 to d492659 Compare September 15, 2021 08:12
@nevermore3 nevermore3 added the ready-for-testing PR: ready for the CI test label Sep 15, 2021
@nevermore3 nevermore3 requested a review from a team September 15, 2021 08:42
yixinglu
yixinglu previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CPWstatic
CPWstatic previously approved these changes Sep 18, 2021
View reviewed changes
CPWstatic
CPWstatic reviewed Sep 18, 2021
View reviewed changes
src/graph/validator/FetchVerticesValidator.cpp Outdated Show resolved Hide resolved
src/parser/parser.yy Show resolved Hide resolved
@nevermore3 nevermore3 force-pushed the format_fetchvertices branch 2 times, most recently from 5ce75f0 to c75a184 Compare September 22, 2021 07:13
@yixinglu yixinglu merged commit fd2e949 into vesoft-inc:master Sep 24, 2021
@yixinglu yixinglu added the doc affected PR: improvements or additions to documentation label Sep 24, 2021
@nevermore3 nevermore3 deleted the format_fetchvertices branch September 24, 2021 03:12
This was referenced Oct 20, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shylock-Hg Shylock-Hg Shylock-Hg left review comments

@CPWstatic CPWstatic CPWstatic approved these changes

@yixinglu yixinglu yixinglu approved these changes

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nevermore3 @yixinglu @CPWstatic @Shylock-Hg