Cancel uploading the packages to the release assets #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
requested review from
CPWstatic,
jievince,
whitewum,
jamieliu1023,
Sophie-Xie and
a team
|
The diff should merge into 2.5.0 release branch for release 2.5.x bugfix. |
|
Why not provide both download methods |
I guess binary assets URLs will be put in the description of each release, and their URLs are OSS/CDN links, thus the telemetry/metrics on downloads would be collected in a more detailed way(i.e. source geoinformation, etc.) |
jievince
approved these changes
Aug 28, 2021
Aiee
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From then on, users need to go to the download page of nebula's official website to download the released installation package and source code package