Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage slow query #2534

Merged
merged 19 commits into from
Sep 6, 2021
Merged

Storage slow query #2534

merged 19 commits into from
Sep 6, 2021

Conversation

cangfengzhs
Copy link
Contributor

No description provided.

@cangfengzhs cangfengzhs requested a review from a team August 18, 2021 10:56
@CLAassistant
Copy link

CLAassistant commented Aug 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

critical27
critical27 previously approved these changes Aug 24, 2021
View reviewed changes
@critical27
Copy link
Contributor

Well done!

liuyu85cn
liuyu85cn previously approved these changes Aug 25, 2021
View reviewed changes
critical27
critical27 previously approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Aug 25, 2021
@cangfengzhs cangfengzhs dismissed stale reviews from critical27 and liuyu85cn via ef7c86f August 25, 2021 02:32
critical27
critical27 previously approved these changes Aug 25, 2021
View reviewed changes
liuyu85cn
liuyu85cn previously approved these changes Aug 25, 2021
View reviewed changes
yixinglu
yixinglu reviewed Aug 25, 2021
View reviewed changes
src/clients/meta/MetaClient.cpp Outdated Show resolved Hide resolved
src/clients/meta/MetaClient.cpp Outdated Show resolved Hide resolved
src/clients/meta/MetaClient.cpp Outdated Show resolved Hide resolved
src/storage/exec/GetNeighborsNode.h Outdated Show resolved Hide resolved
src/storage/mutate/UpdateEdgeProcessor.cpp Outdated Show resolved Hide resolved
@critical27
Copy link
Contributor

Hold on a sec, some code is missing, plz don't merge

@cangfengzhs cangfengzhs dismissed stale reviews from liuyu85cn and critical27 via 04a15d7 August 26, 2021 08:00
critical27
critical27 approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, a good start

@cangfengzhs cangfengzhs linked an issue Aug 27, 2021 that may be closed by this pull request
[STO]Profiling of storage. Kill slow queries (on the storage side) #2599
Closed
@cangfengzhs cangfengzhs requested a review from yixinglu August 27, 2021 08:12
panda-sheep
panda-sheep reviewed Aug 30, 2021
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@critical27 critical27 merged commit 5905860 into vesoft-inc:master Sep 6, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Sep 11, 2021
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@nebula-bots @Shylock-Hg @Sophie-Xie
Support subscript in update. (vesoft-inc#2534)
6a64f08 
Co-authored-by: shylock <[email protected]>
Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panda-sheep panda-sheep panda-sheep left review comments

@liuyu85cn liuyu85cn liuyu85cn approved these changes

@critical27 critical27 critical27 approved these changes

@bright-starry-sky bright-starry-sky Awaiting requested review from bright-starry-sky

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@yixinglu yixinglu Awaiting requested review from yixinglu

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[STO]Profiling of storage. Kill slow queries (on the storage side)
6 participants
@cangfengzhs @CLAassistant @critical27 @yixinglu @liuyu85cn @panda-sheep