Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GetTag and ListTags in MetaServer #249

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Implement GetTag and ListTags in MetaServer #249

merged 3 commits into from
Apr 10, 2019

Conversation

boshengchen
Copy link
Contributor

Tag's storage structure has been change from
value = schema
to
value = int32_t(tag name size) + tag_name + schema

@nebula-community-bot
Copy link
Member

Can one of the admins verify this patch?

@boshengchen
Copy link
Contributor Author

please hold this pr, this depends #225

@sherman-the-tank
Copy link
Member

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@boshengchen
Copy link
Contributor Author

code rebased . please review.

@boshengchen
Copy link
Contributor Author

Ready to review. Come on please .

dangleptr
dangleptr reviewed Apr 9, 2019
View reviewed changes
src/interface/meta.thrift Show resolved Hide resolved
src/meta/processors/ListTagsProcessor.cpp Outdated Show resolved Hide resolved
ayyt
ayyt reviewed Apr 9, 2019
View reviewed changes
src/meta/test/ProcessorTest.cpp Outdated Show resolved Hide resolved
src/meta/test/ProcessorTest.cpp Outdated Show resolved Hide resolved
src/meta/test/ProcessorTest.cpp Outdated Show resolved Hide resolved
src/meta/test/ProcessorTest.cpp Show resolved Hide resolved
@sherman-the-tank
Copy link
Member

jenkins go

sherman-the-tank
sherman-the-tank reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@sherman-the-tank sherman-the-tank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

The PR generally looks good to me, except a few minor comments

src/interface/meta.thrift Show resolved Hide resolved
src/meta/MetaUtils.cpp Outdated Show resolved Hide resolved
src/meta/MetaUtils.cpp Outdated Show resolved Hide resolved
src/meta/test/ProcessorTest.cpp Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

Unit testing passed.

@boshengchen
Copy link
Contributor Author

All conversions resolved.

@darionyaphet darionyaphet changed the title getTag and listTags Implement GetTag Apr 10, 2019
@darionyaphet darionyaphet changed the title Implement GetTag Implement GetTag in MetaServer Apr 10, 2019
@darionyaphet darionyaphet changed the title Implement GetTag in MetaServer Implement GetTag and ListTags in MetaServer Apr 10, 2019
@dangleptr
Copy link
Contributor

Jenkins go

@dangleptr
Copy link
Contributor

dangleptr commented Apr 10, 2019 •
edited
Loading

Besides the interfaces about tag, i think we need another interface "AlterTag" with which we could generate a new version for the existed tag. Of course, we could use another pr for it.

@boshengchen
Copy link
Contributor Author

Besides the interfaces about tag, i think we need another interface "AlterTag" with which we could generate a new version for the existed tag. Of course, we could use another pr for it.

I agreed your plan. we also need to implement the sentences for tag at later.

@boshengchen boshengchen reopened this Apr 10, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

dangleptr
dangleptr approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangleptr dangleptr merged commit 0b33652 into vesoft-inc:master Apr 10, 2019
@boshengchen boshengchen deleted the tag_get branch April 17, 2019 08:01
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@boshengchen @dangleptr
Implement GetTag and ListTags in MetaServer (vesoft-inc#249)
cde3a47 
* getTag and listTags

* rebase master and unify code

* address comments.
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@Aiee
Fix license dir in the default production config (vesoft-inc#249)
9aaa37c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherman-the-tank sherman-the-tank sherman-the-tank left review comments

@darionyaphet darionyaphet darionyaphet left review comments

@ayyt ayyt ayyt left review comments

@dangleptr dangleptr dangleptr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@boshengchen @nebula-community-bot @sherman-the-tank @dangleptr @ayyt @darionyaphet