Implement GoExecutor #245
Merged
Implement GoExecutor #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing passed. |
laura-ding
reviewed
Mar 28, 2019
|
Unit testing passed. |
dangleptr
reviewed
Mar 29, 2019
dangleptr
reviewed
Mar 29, 2019
|
Unit testing failed. |
Was due to leader_election_test. Jenkins, please run |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
zlcook
reviewed
Apr 3, 2019
|
Unit testing passed. |
|
It is still wip now? |
Sorry about this. I have changed the title and add a todo list in the description. |
|
Unit testing failed. |
dangleptr
reviewed
Apr 8, 2019
Was due to failures when building proxygen. |
|
Unit testing passed. |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
|
Well done! The PR now LGTM @dangleptr I'll leave it to you to accept |
dangleptr
approved these changes
Apr 10, 2019
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* [WIP] Implement GoExecutor * Address @laura.ding 's comments * Addressed @dangleptr's comments * Addressed @zlcook's comment * Addressed @sherman-the-tank's and @dangleptr's comments * Fixed a stupid error * Reverted changes on ThriftClientManager * Addressed @sherman-the-tank's comments close vesoft-inc#176 close vesoft-inc#177
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* [WIP] Implement GoExecutor * Address @laura.ding 's comments * Addressed @dangleptr's comments * Addressed @zlcook's comment * Addressed @sherman-the-tank's and @dangleptr's comments * Fixed a stupid error * Reverted changes on ThriftClientManager * Addressed @sherman-the-tank's comments close vesoft-inc#176 close vesoft-inc#177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the basic version of GO and variable, and provide some scripts to operate the daemons.
It's huge, but I hope it's not too hard to read.
todo:
UPTOREVERSELY