MetaServer support general kv storage #243
Conversation
Conflicts: src/interface/meta.thrift
|
Unit testing passed. |
src/meta/processors/GetProcessor.cpp
Outdated
| namespace meta { | ||
|
|
||
| void GetProcessor::process(const cpp2::GetReq& req) { | ||
| guard_ = std::make_unique<std::lock_guard<std::mutex>>( |
There was a problem hiding this comment.
I notice that you and @dangleptr used to use lock_guard like this, i.e. allocate on heap instead of on stack. Could you explain on this?
There was a problem hiding this comment.
some async processor would get value after the method return.
when lock_guard allocated on stack, it's a local variable and the scope is in the method.
so we think it should allocated on the heap :)
src/interface/meta.thrift
Outdated
| } | ||
|
|
||
| struct MultiPutReq { | ||
| 1: list<Pair> pairs |
There was a problem hiding this comment.
For put/get, we should indicate the tableName in request.
The tableName should be kept inside key, and it should has no conflicts with system-level tables(space, hosts, edges, tags etc.)
|
Unit testing failed. |
|
Unit testing failed. |
|
Unit testing passed. |
|
Unit testing failed. |
Conflicts: src/meta/CMakeLists.txt src/meta/MetaServiceHandler.cpp src/meta/MetaServiceHandler.h src/meta/test/ProcessorTest.cpp
|
Unit testing passed. |
|
Unit testing failed. |
1 similar comment
|
Unit testing failed. |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
Conflicts: src/kvstore/NebulaStore.cpp src/kvstore/RocksEngine.cpp src/meta/MetaUtils.cpp
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
|
Unit testing failed. |
1 similar comment
|
Unit testing failed. |
|
Unit testing passed. |
|
Unit testing passed. |
5 similar comments
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
| @@ -24,12 +24,12 @@ void RemoveTagProcessor::process(const cpp2::RemoveTagReq& req) { | |||
| } | |||
| resp_.set_code(cpp2::ErrorCode::SUCCEEDED); | |||
| LOG(INFO) << "Remove Tag " << req.get_tag_name(); | |||
| doRemove(std::move(ret.value())); | |||
| doRemoves(std::move(ret.value())); | |||
|
Unit testing passed. |
Conflicts: src/meta/MetaServiceHandler.cpp src/meta/client/MetaClient.cpp src/meta/processors/BaseProcessor.h src/meta/processors/BaseProcessor.inl src/meta/processors/CreateSpaceProcessor.cpp src/meta/test/MetaClientTest.cpp
|
Unit testing passed. |
|
Unit testing passed. |
* meta server general KV storage * enhance meta kv storage * address dangleptr's comment
* meta server general KV storage * enhance meta kv storage * address dangleptr's comment
Co-authored-by: Yichen Wang <[email protected]>
No description provided.