Refactor schemaManager to support ServerBasedSchemaManager #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing passed. |
dutor
reviewed
Apr 1, 2019
src/meta/SchemaManager.h
Outdated
| std::string name_; | ||
| nebula::cpp2::ValueType type_; | ||
| }; | ||
| static std::unique_ptr<SchemaManager> instance(); |
There was a problem hiding this comment.
A static get or instance often refers to a singleton, here create might be a better name.
dutor
reviewed
Apr 1, 2019
src/meta/SchemaManager.h
Outdated
| GraphSpaceID space, EdgeType edge, int32_t ver = -1) override; | ||
|
|
||
| std::shared_ptr<const SchemaProviderIf> getEdgeSchema( | ||
| const folly::StringPiece spaceName, |
There was a problem hiding this comment.
folly::Range<const char*>, aka. folly::StringPiece, is already immutable, in terms of it's owner. So it not necessary to make the parameter constant. Besides, it makes little sence to make the parameter constant if it's passed by value.
|
Unit testing failed. |
|
Jenkins go |
|
Unit testing passed. |
darionyaphet
previously approved these changes
Apr 10, 2019
|
@dutor Please check the changes inside graph module. If there is no problems, i will merge it later. |
|
Unit testing passed. |
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
…c#241) * Refactor schemaManager to support ServerBasedSchemaManager * Rebase on master
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…c#241) * Refactor schemaManager to support ServerBasedSchemaManager * Rebase on master
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Co-authored-by: jimingquan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor schemaManager to support ServerBasedSchemaManager which will be updated by meta client. It is the foundation about SchemaManager on Meta server (#170 )
The main changes include: