-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the CMakeLists.txt of building jni #2324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
- Coverage 86.46% 86.07% -0.40%
==========================================
Files 649 648 -1
Lines 64374 64706 +332
==========================================
+ Hits 55662 55696 +34
- Misses 8712 9010 +298
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The orignial purpose for the root CMakeLists.txt under jni is to build jni independently only with its own depencies (glog, stl, gcc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for taking care of it.
Please ignore the CI error of snapshot_command_test, I've using #2318 to handle it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.