Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the CMakeLists.txt of building jni #2324

Merged
merged 4 commits into from
Sep 1, 2020
Merged

Modify the CMakeLists.txt of building jni #2324

merged 4 commits into from
Sep 1, 2020

Conversation

laura-ding
Copy link
Contributor

No description provided.

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Aug 27, 2020
@laura-ding laura-ding changed the title Modify the CMakeLists.txt of build jni Modify the CMakeLists.txt of building jni Aug 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #2324 into master will decrease coverage by 0.39%.
The diff coverage is 65.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2324      +/-   ##
==========================================
- Coverage   86.46%   86.07%   -0.40%     
==========================================
  Files         649      648       -1     
  Lines       64374    64706     +332     
==========================================
+ Hits        55662    55696      +34     
- Misses       8712     9010     +298     
Impacted Files Coverage Δ
src/common/hdfs/HdfsCommandHelper.cpp 0.00% <0.00%> (-75.00%) ⬇️
src/graph/DownloadExecutor.cpp 0.00% <0.00%> (ø)
src/graph/DropSpaceExecutor.h 0.00% <ø> (ø)
src/graph/FetchEdgesExecutor.cpp 79.32% <0.00%> (-0.27%) ⬇️
src/graph/FetchVerticesExecutor.cpp 78.21% <0.00%> (-0.18%) ⬇️
src/graph/FindPathExecutor.h 50.00% <ø> (ø)
src/graph/GoExecutor.h 91.30% <ø> (-1.56%) ⬇️
src/graph/IngestExecutor.cpp 0.00% <0.00%> (ø)
src/graph/LookupExecutor.cpp 67.89% <0.00%> (-0.15%) ⬇️
src/graph/test/TestBase.h 70.00% <ø> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87208af...ca6dea6. Read the comment docs.

Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The orignial purpose for the root CMakeLists.txt under jni is to build jni independently only with its own depencies (glog, stl, gcc).

@laura-ding laura-ding requested a review from dangleptr August 27, 2020 05:22
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of it.

@bright-starry-sky
Copy link
Contributor

Please ignore the CI error of snapshot_command_test, I've using #2318 to handle it.

Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dangleptr dangleptr merged commit b548c74 into vesoft-inc:master Sep 1, 2020
xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Sep 12, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants