Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double quote in index #2258

Merged
merged 3 commits into from
Aug 5, 2020
Merged

fix double quote in index #2258

merged 3 commits into from
Aug 5, 2020

Conversation

knightjya
Copy link

What changes were proposed in this pull request?
Fix SparkClientGenerator. The function extraValue add duplicate double quote to index. Remove the quote in INSERT_VALUE_TEMPLATE_WITH_POLICY. ENDPOINT_TEMPLATE need NOT to be changed, because double quote is not duplicate while insert edges. Refers to #2250 #2245

Why are the changes needed?
When using extraValue to transfrom index, double quote was added.
before: duplicate double quote
after: aviod duplicate double quote

Does this PR introduce any user-facing change?
No.

How was this patch tested?
Built jar and test in production environment.

Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangleptr dangleptr added the ready-for-testing PR: ready for the CI test label Aug 5, 2020
@dangleptr dangleptr merged commit b64f0b6 into vesoft-inc:master Aug 5, 2020
xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Sep 12, 2020
Co-authored-by: jiahao_liu <[email protected]>
Co-authored-by: yaphet <[email protected]>
Co-authored-by: dangleptr <[email protected]>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Co-authored-by: jiahao_liu <[email protected]>
Co-authored-by: yaphet <[email protected]>
Co-authored-by: dangleptr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants