fix meta can't be stopped #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
dangleptr,
liuyu85cn,
bright-starry-sky and
panda-sheep
dangleptr
reviewed
Jul 21, 2020
src/daemons/MetaDaemon.cpp
Outdated
| gKVStore.reset(); | ||
| } | ||
| if (gServer) { | ||
| gServer->stop(); |
There was a problem hiding this comment.
Why stop kvstore firstly.
There was a problem hiding this comment.
You're right, fixed.
Codecov Report
@@ Coverage Diff @@
## master #2240 +/- ##
==========================================
- Coverage 86.54% 86.46% -0.08%
==========================================
Files 644 647 +3
Lines 63643 63889 +246
==========================================
+ Hits 55079 55242 +163
- Misses 8564 8647 +83
Continue to review full report at Codecov.
|
dangleptr
approved these changes
Jul 21, 2020
xuguruogu
pushed a commit
to xuguruogu/nebula
that referenced
this pull request
Aug 5, 2020
* fix meta can't be stopped * address comments
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* fix meta can't be stopped * address comments
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
…ds (vesoft-inc#2240) Co-authored-by: Sophie <[email protected]> Co-authored-by: Yichen Wang <[email protected]> Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3-replica meta, stop two followers at first, then leader at last. If leader receive a heartbeat from storage, it will retry forever to updateHostInfo.
The root reason is we didn't stop and release kvstore when we stop daemon.