Check/create edge index #2058
Merged
Check/create edge index #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shylock-Hg
added
type/enhancement
Shylock-Hg
requested review from
darionyaphet,
critical27,
panda-sheep,
bright-starry-sky,
CPWstatic,
dangleptr and
laura-ding
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
==========================================
- Coverage 86.90% 86.79% -0.11%
==========================================
Files 636 641 +5
Lines 59819 61148 +1329
==========================================
+ Hits 51984 53075 +1091
- Misses 7835 8073 +238
Continue to review full report at Codecov.
|
wadeliuyi
reviewed
Apr 6, 2020
dangleptr
previously approved these changes
Jul 14, 2020
|
Please rebase it. Thanks. |
It's auto format. |
| @@ -31,14 +31,24 @@ void CreateEdgeIndexExecutor::execute() { | |||
| auto *edgeName = sentence_->edgeName(); | |||
| auto columns = sentence_->names(); | |||
| auto spaceId = ectx()->rctx()->session()->space(); | |||
| if (UNLIKELY(columns.empty())) { | |||
There was a problem hiding this comment.
The check about column's empty and column duplicate is in meta.
There was a problem hiding this comment.
That's my purpose.
| return Status(k##ERROR, msg); \ | ||
| } \ | ||
| \ | ||
| static Status ERROR(const char *fmt, ...) __attribute__((format(printf, 1, 2))) { \ |
| kNotSupported = 103, | ||
| kError = 101, | ||
| kNoSuchFile = 102, | ||
| kNotSupported = 103, |
dangleptr
approved these changes
Jul 15, 2020
darionyaphet
approved these changes
Jul 17, 2020
xuguruogu
pushed a commit
to xuguruogu/nebula
that referenced
this pull request
Aug 5, 2020
* Check the create edge index request early. * Add some comments. * Using std::move.
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Check the create edge index request early. * Add some comments. * Using std::move.
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
…vesoft-inc#2058) This reverts commit aa62416. Co-authored-by: Sophie <[email protected]> Co-authored-by: Cheng Xuntao <[email protected]> Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sub of #2057
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?