Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC4 Cherrypick #1953 #1973 #1978 #1988

Merged
merged 3 commits into from
Mar 26, 2020
Merged

RC4 Cherrypick #1953 #1973 #1978 #1988

merged 3 commits into from
Mar 26, 2020

Conversation

jude-zhu
Copy link
Contributor

No description provided.

@dangleptr @jude-zhu
Remove removePrefix interface in kvstore (vesoft-inc#1953)
775bee7 
Co-authored-by: heng <[email protected]>
Co-authored-by: yaphet <[email protected]>
(cherry picked from commit 6499c64)
@dangleptr @jude-zhu
Fix the read performance issue after delete range with rocksdb-5.15.10 (
8221606 
vesoft-inc#1973)

* Fix the read performace issue after delete range with rocksdb-5.15.10

* Fix the move issue

* fix the move issue

* Rebase and address bright-starry-sky's comments

Co-authored-by: heng <[email protected]>
(cherry picked from commit 1c1aae5)
@dangleptr @jude-zhu
Remove the LOG(FATAL) when encounting the unknown log type (vesoft-in…
2ebf4ef 
…c#1978)

(cherry picked from commit f114b21)
dangleptr
dangleptr approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Thanks for taking care of it.

darionyaphet
darionyaphet approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangleptr dangleptr added the ready-for-testing PR: ready for the CI test label Mar 26, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v1.0.0-rc4@e6a2d03). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             v1.0.0-rc4    #1988   +/-   ##
=============================================
  Coverage              ?   87.07%           
=============================================
  Files                 ?      641           
  Lines                 ?    60881           
  Branches              ?        0           
=============================================
  Hits                  ?    53010           
  Misses                ?     7871           
  Partials              ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a2d03...2ebf4ef. Read the comment docs.

@dangleptr dangleptr merged commit 50b2af1 into vesoft-inc:v1.0.0-rc4 Mar 26, 2020
@jude-zhu jude-zhu deleted the cherry branch June 10, 2020 06:51
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
@nebula-bots @jievince
fix wrong vid finder for logic or expr (vesoft-inc#1988)
85cb6c8 
* fix wrong vid finder

* add tck cases

Co-authored-by: jie.wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangleptr dangleptr dangleptr approved these changes

@darionyaphet darionyaphet darionyaphet approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jude-zhu @codecov-io @darionyaphet @dangleptr