Check the index have existed although the name not the same #1695

darionyaphet · 2020-01-21T08:51:33Z

No description provided.

src/meta/processors/indexMan/CreateEdgeIndexProcessor.cpp

dangleptr · 2020-02-03T09:57:51Z

src/meta/processors/indexMan/CreateEdgeIndexProcessor.cpp

+        }
+
+        for (size_t i = 0; i < fieldNames.size(); i++) {
+            if (fieldNames[i] != item.get_fields()[i].get_name()) {


Do you ensure the item have the same number fields as the filedNames?

In fact, when the index's field is disaccord, they are not the same.

So maybe access invalid index on "item.get_fields()[i]"

Add a checker, if the size of current index is longer than the previous one , it will skip.

bright-starry-sky · 2020-02-10T09:43:58Z

src/meta/processors/indexMan/CreateTagIndexProcessor.cpp

+    while (checkIter->valid()) {
+        auto val = checkIter->val();
+        auto item = MetaServiceUtils::parseIndex(val);
+        if (item.get_schema_id().getType() != nebula::cpp2::SchemaID::Type::tag_id) {
+            continue;
+        }
+
+        for (size_t i = 0; i < fieldNames.size(); i++) {
+            if (fieldNames[i] != item.get_fields()[i].get_name()) {
+                break;
+            }
+
+            if (i == fieldNames.size() - 1) {
+                LOG(ERROR) << "Tag Index " << indexName << " have existed";
+                resp_.set_code(cpp2::ErrorCode::E_EXISTED);
+                onFinished();
+                return;
+            }
+        }
+        checkIter->next();
+    }


For example , exist index1 (col1, col2), then we want create index2(col1, col2, col4), is it work well?

Sure.

In the test case single_index create on name and multi_index indexed on name and email. It's work.

src/meta/processors/indexMan/CreateTagIndexProcessor.cpp

dangleptr · 2020-02-11T07:12:56Z

src/meta/processors/indexMan/CreateTagIndexProcessor.cpp

@@ -43,6 +43,38 @@ void CreateTagIndexProcessor::process(const cpp2::CreateTagIndexReq& req) {
        return;
    }

+    auto prefix = MetaServiceUtils::indexPrefix(space);


Could we unify the code.

codecov-io · 2020-03-24T08:33:34Z

Codecov Report

Merging #1695 into master will increase coverage by 0.25%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
+ Coverage   86.90%   87.15%   +0.25%     
==========================================
  Files         636      641       +5     
  Lines       59819    61163    +1344     
==========================================
+ Hits        51984    53307    +1323     
- Misses       7835     7856      +21

Impacted Files	Coverage Δ
src/graph/DescribeSpaceExecutor.h	`0.00% <ø> (ø)`
src/graph/FetchEdgesExecutor.h	`0.00% <ø> (ø)`
src/graph/FetchExecutor.cpp	`87.77% <ø> (-0.53%)`	⬇️
src/graph/FetchVerticesExecutor.h	`0.00% <ø> (ø)`
src/graph/GoExecutor.h	`56.25% <ø> (ø)`
src/graph/GraphService.h	`100.00% <ø> (ø)`
src/graph/PrivilegeExecutor.h	`69.56% <ø> (+13.04%)`	⬆️
src/graph/SequentialExecutor.h	`0.00% <ø> (ø)`
src/graph/UseExecutor.h	`0.00% <ø> (ø)`
src/graph/test/SchemaTest.cpp	`96.27% <ø> (-1.07%)`	⬇️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0871c69...b1984f7. Read the comment docs.

Shylock-Hg · 2020-04-03T09:25:25Z

src/meta/processors/BaseProcessor.inl

@@ -454,5 +454,21 @@ BaseProcessor<RESP>::indexCheck(const std::vector<nebula::cpp2::IndexItem>& item
    return cpp2::ErrorCode::SUCCEEDED;
 }

+template<typename RESP>


I think better put this function to processor/indexMan/ folder, because it's not the concept of BaseProcessor.

Please check item.get_fields().szie() >= fields.size().

before we check the index have checked the fields size.

src/meta/processors/BaseProcessor.inl

dangleptr · 2020-07-14T05:01:20Z

It is a bug. We should address it in next version. @darionyaphet Could you rebase it?

dangleptr

LGTM.

Co-authored-by: Sophie <[email protected]> Co-authored-by: hs.zhang <[email protected]> Co-authored-by: Sophie <[email protected]>

darionyaphet added the ready-for-testing PR: ready for the CI test label Jan 21, 2020

darionyaphet requested review from dutor, critical27, dangleptr, laura-ding, jude-zhu, liuyu85cn and bright-starry-sky January 21, 2020 08:51

darionyaphet self-assigned this Jan 21, 2020

bright-starry-sky reviewed Jan 21, 2020

View reviewed changes

src/meta/processors/indexMan/CreateEdgeIndexProcessor.cpp Outdated Show resolved Hide resolved

dangleptr reviewed Feb 3, 2020

View reviewed changes

jude-zhu requested a review from dangleptr February 4, 2020 06:57

bright-starry-sky reviewed Feb 10, 2020

View reviewed changes

src/meta/processors/indexMan/CreateTagIndexProcessor.cpp Outdated Show resolved Hide resolved

bright-starry-sky reviewed Feb 10, 2020

View reviewed changes

src/meta/processors/indexMan/CreateTagIndexProcessor.cpp Outdated Show resolved Hide resolved

dangleptr reviewed Feb 11, 2020

View reviewed changes

bright-starry-sky mentioned this pull request Mar 18, 2020

Reject create duplicate index. #1931

Closed

Shylock-Hg linked an issue Mar 18, 2020 that may be closed by this pull request

Reject create duplicate index. #1931

Closed

jude-zhu requested review from dangleptr and bright-starry-sky March 23, 2020 03:52

Shylock-Hg reviewed Apr 3, 2020

View reviewed changes

bright-starry-sky reviewed Apr 6, 2020

View reviewed changes

src/meta/processors/BaseProcessor.inl Show resolved Hide resolved

jude-zhu requested review from Shylock-Hg and bright-starry-sky April 7, 2020 07:13

dangleptr added the priority/low-pri Priority: low label Jul 14, 2020

check index field conflict

6742fb2

dangleptr approved these changes Jul 17, 2020

View reviewed changes

bright-starry-sky approved these changes Jul 17, 2020

View reviewed changes

Merge branch 'master' into index-conflict

6405dd4

dangleptr merged commit eedd52b into vesoft-inc:master Jul 17, 2020

xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Aug 5, 2020

check index field conflict (vesoft-inc#1695)

9c57c24

tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021

check index field conflict (vesoft-inc#1695)

86141d1

yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023

reduce link threads to avoid OOM (vesoft-inc#1695)

c602bc5

Co-authored-by: Sophie <[email protected]> Co-authored-by: hs.zhang <[email protected]> Co-authored-by: Sophie <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check the index have existed although the name not the same #1695

Check the index have existed although the name not the same #1695

darionyaphet commented Jan 21, 2020

dangleptr Feb 3, 2020 •

edited

Loading

darionyaphet Feb 3, 2020

dangleptr Feb 7, 2020

darionyaphet Feb 10, 2020

bright-starry-sky Feb 10, 2020

darionyaphet Feb 10, 2020

dangleptr Feb 11, 2020

codecov-io commented Mar 24, 2020

Shylock-Hg Apr 3, 2020

Shylock-Hg Apr 3, 2020

darionyaphet Jul 17, 2020

dangleptr commented Jul 14, 2020

dangleptr left a comment

Check the index have existed although the name not the same #1695

Check the index have existed although the name not the same #1695

Conversation

darionyaphet commented Jan 21, 2020

dangleptr Feb 3, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Mar 24, 2020

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dangleptr commented Jul 14, 2020

dangleptr left a comment

Choose a reason for hiding this comment

dangleptr Feb 3, 2020 •

edited

Loading