Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some comments in CMakeLists.txt #1562

Merged
merged 3 commits into from
Jan 2, 2020
Merged

Added some comments in CMakeLists.txt #1562

merged 3 commits into from
Jan 2, 2020

Conversation

amber-moe
Copy link
Contributor

as title. updated some comments

whitewum
whitewum previously approved these changes Dec 31, 2019
laura-ding
laura-ding previously approved these changes Dec 31, 2019
@dutor dutor added the ready-for-testing PR: ready for the CI test label Dec 31, 2019
@dutor
Copy link
Contributor

dutor commented Dec 31, 2019

Suspend this PR until #1332 is merged

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor
Copy link
Contributor

dutor commented Jan 1, 2020

Now there are conflicts, please resolve them first.

@amber-moe amber-moe dismissed stale reviews from laura-ding and whitewum via e775b85 January 2, 2020 02:21
@nebula-community-bot
Copy link
Member

Unit testing passed.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebula-community-bot
Copy link
Member

Unit testing failed.

@dutor
Copy link
Contributor

dutor commented Jan 2, 2020

Jenkins go

1 similar comment
@dutor
Copy link
Contributor

dutor commented Jan 2, 2020

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor changed the title [doc]cMakeLists update Added some comments in CMakeLists.txt Jan 2, 2020
@dutor dutor merged commit 1a1be6e into vesoft-inc:master Jan 2, 2020
@amber-moe amber-moe deleted the cmakeLists-update branch January 6, 2020 02:46
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* cMakeLists update

* darion

Co-authored-by: yaphet <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* only create 1 part in tck

* Update NebulaStoreTest.cpp

* Update test_space.py

* Update test_space.py

* Update Comment.feature

* enable ubuntu gcc

* enable ubuntu2004-gcc

* use nebula runner

Co-authored-by: Doodle <[email protected]>
Co-authored-by: Sophie <[email protected]>
Co-authored-by: 谢振宁 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants