Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ccache to speed up build and fix dockerfile for gflags #1510

Merged
merged 9 commits into from
Jan 6, 2020

Conversation

yixinglu
Copy link
Contributor

Try to use ccache to speed up build

close #1506

@yixinglu yixinglu changed the title Enable ccache for speeding up build and fix dockerfile for gflags Enable ccache to speed up build and fix dockerfile for gflags Dec 24, 2019
@yixinglu yixinglu added the do not review PR: not ready for the code review yet label Dec 24, 2019
dutor
dutor previously approved these changes Dec 26, 2019
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jude-zhu jude-zhu requested a review from laura-ding December 26, 2019 07:51
@yixinglu yixinglu force-pushed the ccache branch 9 times, most recently from 1575305 to fe96c30 Compare December 26, 2019 15:52
@yixinglu yixinglu added ready-for-testing PR: ready for the CI test and removed do not review PR: not ready for the code review yet labels Dec 26, 2019
@yixinglu
Copy link
Contributor Author

Jenkins go

@yixinglu yixinglu requested a review from dutor December 26, 2019 16:06
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@jude-zhu jude-zhu requested a review from knightXun December 27, 2019 02:08
dutor
dutor previously approved these changes Dec 27, 2019
@yixinglu yixinglu added do not review PR: not ready for the code review yet and removed ready-for-testing PR: ready for the CI test labels Dec 27, 2019
@yixinglu
Copy link
Contributor Author

@dutor please wait a minute for merging, I will use self-hosted runners to run our build jobs.

Update docker hub url

Use tmpfs for ccache

Limit 1G tmpfs size

Use container env to simplify steps environment variables

Add centos6 job

Fix ccache dir in centos6

Specify CC/CXX environment variables to fix node error

Fix env var

Try to fix cmake error

Add centos cache job again

Fix cache key and restore keys

Fix echo string error

Update ccache directory

Remove write ccache conf cmd

Format

Use common job env

Fix centos6 job

Use LD_LIBRARY_PATH to fix centos 6 dep error of node 12

Setup node version

Test customed actions

Fix no cache for apk installation

Try to fix entrypoint

Fix entrypoint

Use docker container to cache

Use docker to run build and test

Use sudo to mount tmpfs

Fix tty error

Fix tmpfs mount point

Fix mount error

Delete cache actions
@yixinglu yixinglu added ready-for-testing PR: ready for the CI test and removed do not review PR: not ready for the code review yet labels Jan 6, 2020
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@dutor dutor requested a review from monadbobo January 6, 2020 05:34
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yixinglu
Copy link
Contributor Author

yixinglu commented Jan 6, 2020

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 7b88e78 into vesoft-inc:master Jan 6, 2020
@yixinglu yixinglu deleted the ccache branch January 6, 2020 06:03
@nebula-community-bot
Copy link
Member

Unit testing passed.

tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
…-inc#1510)

* Enable ccache for building and fix dockerfile for gflags

Update docker hub url

Use tmpfs for ccache

Limit 1G tmpfs size

Use container env to simplify steps environment variables

Add centos6 job

Fix ccache dir in centos6

Specify CC/CXX environment variables to fix node error

Fix env var

Try to fix cmake error

Add centos cache job again

Fix cache key and restore keys

Fix echo string error

Update ccache directory

Remove write ccache conf cmd

Format

Use common job env

Fix centos6 job

Use LD_LIBRARY_PATH to fix centos 6 dep error of node 12

Setup node version

Test customed actions

Fix no cache for apk installation

Try to fix entrypoint

Fix entrypoint

Use docker container to cache

Use docker to run build and test

Use sudo to mount tmpfs

Fix tty error

Fix tmpfs mount point

Fix mount error

Delete cache actions

* Use self hosted runner

* Improve cmake scripts

* Add timeout seconds for ctest

* Cleanup

* Fix gcc warning for lower version

* Execute cmake steps with condition

* Limit ctest parallels

Co-authored-by: dutor <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* Introduce JSON_EXTRACT function

close: vesoft-inc#3513
Note, we don't support the path argument in this phase

* address jievince's review commit

removed the unecessary interface of construct Map from Value

* Type handling

Only primitive types are supported

* Support depth1 nested

* lint: fmt

* ut: ctest, fixed wrong expression of Map

* fix ut errors

* tck: case for json_extract added

Co-authored-by: Sophie <[email protected]>

Co-authored-by: Wey Gu <[email protected]>
Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ccache and GitHub Actions cache to speed up workflows
4 participants