Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]add if not exists #1407

Merged
merged 6 commits into from
Dec 18, 2019
Merged

[doc]add if not exists #1407

merged 6 commits into from
Dec 18, 2019

Conversation

amber-moe
Copy link
Contributor

Add if not exist in create space and tag/edge

monadbobo
monadbobo previously approved these changes Dec 11, 2019
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

```

This statement creates a new space with the given name. SPACE is a region that provides physically isolated graphs in **Nebula Graph**. An error occurs if the database exists.

## IF NOT EXIST

We added the `If NOT EXIST` keywords for creating spaces. This keyword automatically detects if the corresponding space exists. If it does not exist, a new one is created. Otherwise, no space is created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyword not keywords

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree. 3 words here.

@@ -21,6 +21,12 @@ CREATE {TAG | EDGE} <tag_name> | <edge_name>

The features of this syntax are described in the following sections:

## IF NOT EXIST

We added the `If NOT EXIST` keywords for creating tags or edges. This keyword automatically detects if the corresponding tag or edge exists. If it does not exist, a new one is created. Otherwise, no tag or edge is created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyword

Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some errors

@amber-moe amber-moe changed the title [doc]add if not exist [doc]add if not exists Dec 16, 2019
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Dec 18, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 008c297 into vesoft-inc:master Dec 18, 2019
@amber-moe amber-moe deleted the if-not-exist branch December 19, 2019 03:43
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* add if not exist

* comments

* jie

* wum

* update query syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants