Refactor JNI library #1402
Merged
Refactor JNI library #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2019 16:32
dangleptr
requested review from
sherman-the-tank,
bright-starry-sky,
critical27,
darionyaphet and
liuyu85cn
|
Unit testing passed. |
critical27
reviewed
Dec 12, 2019
| mutable std::vector<int64_t> offsets_; | ||
|
|
||
| private: | ||
| static int32_t getSchemaVer(Slice row); |
There was a problem hiding this comment.
Do we need to unify the type of schema version? The SchemaVer used in thrift is int64_t
src/jni/java/pom.xml
Outdated
|
|
||
| <groupId>com.vesoft</groupId> | ||
| <artifactId>nebula-utils</artifactId> | ||
| <version>1.0.0-beta</version> |
|
There is another problems, when I add |
|
Unit testing passed. |
critical27
previously approved these changes
Dec 12, 2019
src/jni/src/datamanlite/RowReader.h
Outdated
| public: | ||
| template<typename T> | ||
| typename std::enable_if<std::is_integral<T>::value, ResultType>::type | ||
| getInt(T& v) const noexcept; |
src/jni/src/datamanlite/RowReader.h
Outdated
| // A negative number will be returned if an error occurs | ||
| template<typename T> | ||
| typename std::enable_if<std::is_integral<T>::value, int32_t>::type | ||
| readInteger(int64_t offset, T& v) const noexcept; |
src/jni/src/datamanlite/RowReader.h
Outdated
| // When succeeded, offset will advance | ||
| template<typename T> | ||
| typename std::enable_if<std::is_integral<T>::value, ResultType>::type | ||
| getInt(int64_t index, int64_t& offset, T& v) const noexcept; |
| break; | ||
| } | ||
| case ValueType::FLOAT: { | ||
| // Eight bytes |
critical27
reviewed
Dec 13, 2019
| private static final Logger LOGGER = LoggerFactory.getLogger(NebulaCodec.class.getName()); | ||
|
|
||
| static { | ||
| System.loadLibrary("nebula_codec"); |
There was a problem hiding this comment.
We'd better catch exception/error here, when java client import this as dependency, will throw exception and error.
try {
System.loadLibrary("nebula_codec");
} catch (Exception e) {
LOGGER.error(e.getMessage(), e);
} catch (Error e) {
LOGGER.error(e.getMessage(), e);
}
|
Unit testing passed. |
critical27
approved these changes
Dec 13, 2019
darionyaphet
approved these changes
Dec 16, 2019
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Refactor jni * Add UTs * Rename class * Update interfaces * Address critical27 and darion's comments * Address darion's comments
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
add test case dispatch to null value fix ut fix scan edge fix fix tck Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old jni lib depends on fbthrift, it is unfriendly when our users want to compile it locally.
Now, the new JNI library only depends on STL and glog.
Our users could build it more easily by themself.
For datamanlite, it is a simpler codec library than dataman. Although there are some duplicate codes currently, it will be cleaned up after @sherman-the-tank refactor it.
Of course, we fix serval bugs during the development. :(