Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]update java client link #1270

Merged
merged 4 commits into from
Nov 18, 2019
Merged

[doc]update java client link #1270

merged 4 commits into from
Nov 18, 2019

Conversation

amber-moe
Copy link
Contributor

No description provided.

darionyaphet
darionyaphet previously approved these changes Nov 14, 2019
@amber-moe amber-moe added the ready-for-testing PR: ready for the CI test label Nov 15, 2019
@jude-zhu jude-zhu self-requested a review November 15, 2019 02:27
@jude-zhu
Copy link
Contributor

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this URL seems not the how to build ?

@amber-moe amber-moe dismissed darionyaphet’s stale review November 18, 2019 07:01

link is the java client repo

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit 718fd3b into vesoft-inc:master Nov 18, 2019
@amber-moe amber-moe deleted the java-client-link branch November 18, 2019 10:51
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

## What type of PR is this?
- [x] bug
- [ ] feature
- [ ] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 

#### Description:
fix `list tag/edge/tagindex/edgeindex` logic to display data correctly. 
Although it was discovered by the enterprise version, the community version also has the same problem.

`list tag/edge/tagindex/edgeindex` logic has problems, resulting in display wrong data


The test case is as follows(used for enterprise version):
1) The master cluster is in the synchronous state at the beginning, do the following:
```
show sync status;
create tag player1(name string, age int, p3 int, p4 int);
stop sync
```

2) Suppose the slave cluster did the following before synchronizing:
```
create tag index fix on player1(p3);
desc tag index fix
show tag indexes
```
![image](https://user-images.githubusercontent.com/59197347/187812372-82648ca4-7d3c-4ecc-bcda-a72120dc056a.png)



3) The master cluster does the following:
```
create tag index fix on player1(age);
desc tag index fix
show tag indexes
```
![image](https://user-images.githubusercontent.com/59197347/187812436-e645a772-d96b-4d0d-a2a0-5f5e08c3ed85.png)

4)Then the master cluster starts synchronization
` restart sync`
At this time, the following results are displayed from the slave cluster
`desc tag index fix`
![image](https://user-images.githubusercontent.com/59197347/187812486-49493b43-8d3f-46cc-b660-64d48c4ea277.png)
The result is displayed correctly

`show tag indexes`
![image](https://user-images.githubusercontent.com/59197347/187812539-a077311e-c9cd-4aec-9359-18a23f3e7711.png)

Dirty data is displayed, and the expected result is consistent with the master cluster

close vesoft-inc#1236


## How do you solve it?



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.)
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4616

Co-authored-by: panda-sheep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants