Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance stop #1238

Merged
merged 5 commits into from
Nov 12, 2019
Merged

Balance stop #1238

merged 5 commits into from
Nov 12, 2019

Conversation

critical27
Copy link
Contributor

  1. Support stop balance. For all balance tasks which has not started yet, we mark them as stopped. For those tasks which has started, we don't interrupt them.

We can run balance data stop in console. Just like balance data, it will return running balance plan id (if no valid plan running, an error is returned). You can check the status by balance data id. Once remaining tasks has finished, you can trigger the plan by balance data to continue all tasks stopped previously.

  1. Modify leader balance only consider balancing between hosts with valid partitions.

@critical27
Copy link
Contributor Author

Jenkins go

src/meta/processors/admin/Balancer.cpp Show resolved Hide resolved
src/meta/processors/admin/Balancer.cpp Outdated Show resolved Hide resolved
src/meta/processors/admin/Balancer.cpp Outdated Show resolved Hide resolved
src/meta/processors/admin/Balancer.cpp Outdated Show resolved Hide resolved
src/meta/processors/admin/Balancer.cpp Outdated Show resolved Hide resolved
src/meta/processors/admin/Balancer.cpp Outdated Show resolved Hide resolved
src/meta/processors/admin/Balancer.cpp Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

Unit testing passed.

3 similar comments
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@critical27
Copy link
Contributor Author

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. LGTM

@nebula-community-bot
Copy link
Member

Unit testing passed.

@darionyaphet
Copy link
Contributor

Great work!

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit e1ef41b into vesoft-inc:master Nov 12, 2019
@critical27 critical27 deleted the balance branch November 12, 2019 08:28
@jude-zhu
Copy link
Contributor

close #1032

yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
* balance stop

* address dangleptr's comments

* update log, fix ut
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* balance stop

* address dangleptr's comments

* update log, fix ut
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants