-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed crash in builtin function right() #1099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
requested review from
monadbobo,
yixinglu,
darionyaphet,
CPWstatic,
critical27,
laura-ding and
whitewum
October 16, 2019 09:50
yixinglu
previously approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unit testing failed. |
Unit testing passed. |
laura-ding
approved these changes
Oct 16, 2019
yixinglu
approved these changes
Oct 17, 2019
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Fixed crash in builtin function right() * Fixed ut failure
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* runnable navycache add nvm cache lookup draft done add some comments rename file and add comments finish core funcs unit test done adjust the dram size and now nvm cache test can pass return nullptr when itemhandle is nullptr on Lookup() changed the interface multiple rocksdb share the same secondary instance on the same node for debug set the default secondary cache size to 0 to meta will not use it change gflag type add UUL add bucket power and lock power to conf move impl from CahcelibLRU.h to cpp and clean * type and config * remove comment * cmake * add override * change the default cache file size to 0 * set cache size unsigned long * rebase and add comments * rebase Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crashed due to out-of-range accessing.