Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash in builtin function right() #1099

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Fixed crash in builtin function right() #1099

merged 3 commits into from
Oct 17, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Oct 16, 2019

Crashed due to out-of-range accessing.

yixinglu
yixinglu previously approved these changes Oct 16, 2019
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 6342c0a into vesoft-inc:master Oct 17, 2019
@dutor dutor deleted the fix-builtin-right branch October 17, 2019 02:13
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Fixed crash in builtin function right()

* Fixed ut failure
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* runnable navycache

add nvm cache

lookup draft done

add some comments

rename file and add comments

finish core funcs

unit test done

adjust the dram size and now nvm cache test can pass

return nullptr when itemhandle is nullptr on Lookup()

changed the interface

multiple rocksdb share the same secondary instance on the same node

for debug

set the default secondary cache size to 0 to meta will not use it

change gflag type

add UUL

add bucket power and lock power to conf

move impl from CahcelibLRU.h to cpp and clean

* type and config

* remove comment

* cmake

* add override

* change the default cache file size to 0

* set cache size unsigned long

* rebase and add comments

* rebase

Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants