You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As for these tests, I think there are two ways to make them faster. First, we could have shared the same MockServer instead of launch one per test. Second, seconds is appropriate for a polling interval, but too long for unit testing, while I cannot come up with a better way. But you still could impove it by usleep(FLAGS_load_data_interval_secs * 1000000 + 100000/*100ms*/) to save 0.9s per sleep.
Of course, we could leave these work to the next PR.
As for these tests, I think there are two ways to make them faster. First, we could have shared the same MockServer instead of launch one per test. Second, seconds is appropriate for a polling interval, but too long for unit testing, while I cannot come up with a better way. But you still could impove it by
usleep(FLAGS_load_data_interval_secs * 1000000 + 100000/*100ms*/)
to save 0.9s per sleep.Of course, we could leave these work to the next PR.
Originally posted by @dutor in #383
The text was updated successfully, but these errors were encountered: