Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the sleep time in UTs #398

Closed
dangleptr opened this issue May 17, 2019 · 2 comments
Closed

Optimize the sleep time in UTs #398

dangleptr opened this issue May 17, 2019 · 2 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@dangleptr
Copy link
Contributor

As for these tests, I think there are two ways to make them faster. First, we could have shared the same MockServer instead of launch one per test. Second, seconds is appropriate for a polling interval, but too long for unit testing, while I cannot come up with a better way. But you still could impove it by usleep(FLAGS_load_data_interval_secs * 1000000 + 100000/*100ms*/) to save 0.9s per sleep.

Of course, we could leave these work to the next PR.

Originally posted by @dutor in #383

@dutor dutor added the type/enhancement Type: make the code neat or more efficient label May 17, 2019
@dangleptr
Copy link
Contributor Author

duration_test .................... Passed 11.04 sec
stats_manager_test ............... Passed 63.02 sec
meta_client_test ................. Passed 16.11 sec
file_based_wal_test .............. Passed 8.30 sec
log_append_test .................. Passed 16.29 sec
log_cas_test ..................... Passed 43.20 sec

@sherman-the-tank
Copy link
Member

Yeah, let's tackle this 👍

@jude-zhu jude-zhu closed this as completed Aug 7, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

4 participants