You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please check the FAQ documentation before raising an issue
Describe the bug (required)
Take a look at this issue #3434 , after reviewing GraphDaemon's code, we suspect that it may suffer from the same problem since it call gServer->stop() in signal handler(gServer is a ThriftServer instance, if the handler is triggered and scheduled to execute in one of the ThriftServer's worker thread, it may block forever):
#### What type of PR is this?
- [x] bug
- [ ] feature
- [ ] enhancement
#### What does this PR do?
closesvesoft-inc#3441
simplify graphd signal handler:Set stop condition instead of waiting all workers stop
#### Which issue(s)/PR(s) this PR relates to?
In vesoft-inc#3437 , it simplify storage SIGINT signal handler
#### Special notes for your reviewer, ex. impact of this fix, etc:
#### Additional context/ Design document:
#### Checklist:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory
#### Release notes:
Please confirm whether to be reflected in release notes and how to describe:
> `
Migrated from vesoft-inc#3542
Co-authored-by: endy.li <[email protected]>
Please check the FAQ documentation before raising an issue
Describe the bug (required)
Take a look at this issue #3434 , after reviewing GraphDaemon's code, we suspect that it may suffer from the same problem since it call
gServer->stop()
in signal handler(gServer
is a ThriftServer instance, if the handler is triggered and scheduled to execute in one of the ThriftServer's worker thread, it may block forever):nebula/src/daemons/GraphDaemon.cpp
Lines 199 to 209 in cd2f4a6
Your Environments (required)
uname -a
g++ --version
orclang++ --version
lscpu
a3ffc7d8
)How To Reproduce(required)
Steps to reproduce the behavior:
Expected behavior
Additional context
The text was updated successfully, but these errors were encountered: