Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Move the version info outside the heartbeat request #3055

Closed
yixinglu opened this issue Oct 13, 2021 · 0 comments · Fixed by #3378
Closed

Refactoring: Move the version info outside the heartbeat request #3055

yixinglu opened this issue Oct 13, 2021 · 0 comments · Fixed by #3378
Assignees
@heroicNeZha
Labels
incompatible PR: incompatible with the recently released version type/enhancement Type: make the code neat or more efficient
Milestone
v3.0.0

Comments

@yixinglu
Copy link
Contributor

Now meta client sends version info in each heartbeat request. That seems not necessary. we could take them when establishing the connection to metad server.

In addition, built-time maybe need to save in meta same as version info. consider to add a new field in request structure to do that.

This refactoring will affect the compatibility of different nebula versions. Do it in next version.
@yixinglu yixinglu added the type/feature req Type: feature request label Oct 13, 2021
@yixinglu yixinglu added this to the v3.0.0 milestone Oct 13, 2021
@yixinglu yixinglu added type/enhancement Type: make the code neat or more efficient incompatible PR: incompatible with the recently released version later and removed type/feature req Type: feature request labels Oct 13, 2021
@Sophie-Xie Sophie-Xie removed the later label Oct 15, 2021
@jamieliu1023 jamieliu1023 mentioned this issue Oct 20, 2021
Closed
@Sophie-Xie Sophie-Xie moved this to Backlog in Nebula Graph v3.0.0 Oct 28, 2021
@jamieliu1023 jamieliu1023 mentioned this issue Nov 1, 2021
Closed
@heroicNeZha heroicNeZha moved this from Backlog to Designing in Nebula Graph v3.0.0 Nov 10, 2021
@Sophie-Xie Sophie-Xie moved this from Designing to Coding in Nebula Graph v3.0.0 Nov 27, 2021
@heroicNeZha heroicNeZha mentioned this issue Nov 29, 2021
Merged
7 tasks
@heroicNeZha heroicNeZha moved this from Coding to Reviewing in Nebula Graph v3.0.0 Nov 29, 2021
@heroicNeZha heroicNeZha linked a pull request Dec 1, 2021 that will close this issue
Move version info outside of HB #3378
Merged
7 tasks
Repository owner moved this from Reviewing to Done in Nebula Graph v3.0.0 Dec 7, 2021
@jamieliu1023 jamieliu1023 mentioned this issue Dec 11, 2021
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
@nebula-bots @heroicNeZha
Move version info outside of HB (vesoft-inc#344)
b7747b5 
#### What type of PR is this?
- [ ] bug
- [ ] feature
- [x] enhancement

#### What does this PR do?
1. Move the version info outside the heartbeat
2. Save the version info when establishing the connection to metad server.

#### Which issue(s)/PR(s) this PR relates to?
vesoft-inc#3055 

#### Special notes for your reviewer, ex. impact of this fix, etc:


#### Additional context:


#### Checklist：
- [ ] Documentation affected （Please add the label if documentation needs to be modified.)
- [x] Incompatible （If it is incompatible, please describe it and add corresponding label.）
- [ ] Need to cherry-pick （If need to cherry-pick to some branches, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


#### Release notes：
Please confirm whether to reflect in release notes and how to describe:
>                                                                 `


Migrated from vesoft-inc#3378

Co-authored-by: endy.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heroicNeZha heroicNeZha

Labels
incompatible PR: incompatible with the recently released version type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Nebula Graph v3.0.0
Status: Done
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Move version info outside of HB heroicNeZha/nebula
3 participants
@yixinglu @heroicNeZha @Sophie-Xie