fix push efilter down

vesoft-inc · Dec 7, 2022 · efcacb6 · efcacb6
1 parent de02384
commit efcacb6
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/graph/optimizer/rule/PushEFilterDownRule.cpp b/src/graph/optimizer/rule/PushEFilterDownRule.cpp
@@ -144,7 +144,7 @@ std::string PushEFilterDownRule::toString() const {
                                                             const storage::cpp2::EdgeProp &edge,
                                                             meta::SchemaManager *schemaMng,
                                                             ObjectPool *pool) {
-  auto edgeNameResult = schemaMng->toEdgeName(spaceId, edge.get_type());
+  auto edgeNameResult = schemaMng->toEdgeName(spaceId, std::abs(edge.get_type()));
   if (!edgeNameResult.ok()) {
     return nullptr;
   }

diff --git a/tests/tck/features/optimizer/PushEFilterDownRule.feature b/tests/tck/features/optimizer/PushEFilterDownRule.feature
@@ -25,6 +25,34 @@ Feature: Push EFilter down rule
       | 8  | Traverse  | 7            | {"edge filter": "", "filter": "(like.likeness==95)"} |
       | 7  | IndexScan | 0            |                                                      |
       | 0  | Start     |              |                                                      |
+    When profiling query:
+      """
+      MATCH (v:player{name: 'Tim Duncan'})<-[e:like{likeness: 95}]-() return v.player.name AS name
+      """
+    Then the result should be, in any order:
+      | name         |
+      | "Tim Duncan" |
+      | "Tim Duncan" |
+    And the execution plan should be:
+      | id | name      | dependencies | operator info                                        |
+      | 5  | Project   | 8            |                                                      |
+      | 8  | Traverse  | 7            | {"edge filter": "", "filter": "(like.likeness==95)"} |
+      | 7  | IndexScan | 0            |                                                      |
+      | 0  | Start     |              |                                                      |
+    When profiling query:
+      """
+      MATCH (v:player{name: 'Tim Duncan'})-[e:like{likeness: 95}]-() return v.player.name AS name
+      """
+    Then the result should be, in any order:
+      | name         |
+      | "Tim Duncan" |
+      | "Tim Duncan" |
+    And the execution plan should be:
+      | id | name      | dependencies | operator info                                        |
+      | 5  | Project   | 8            |                                                      |
+      | 8  | Traverse  | 7            | {"edge filter": "", "filter": "(like.likeness==95)"} |
+      | 7  | IndexScan | 0            |                                                      |
+      | 0  | Start     |              |                                                      |
     When profiling query:
       """
       MATCH (v:player{name: 'Tim Duncan'})-[e:like*1..2{likeness: 95}]->() return v.player.name AS name