Upgrade checkstyle to 8.18 and remove some useless code (#281)

vesoft-inc · Apr 17, 2019 · e07b105 · e07b105
1 parent a84f057
commit e07b105
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 24 deletions.
diff --git a/src/client/java/pom.xml b/src/client/java/pom.xml
@@ -62,7 +62,7 @@
                     <dependency>
                         <groupId>com.puppycrawl.tools</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>8.11</version>
+                        <version>8.18</version>
                     </dependency>
                 </dependencies>
             </plugin>

diff --git a/src/tools/importer/pom.xml b/src/tools/importer/pom.xml
@@ -58,7 +58,7 @@
                     <dependency>
                         <groupId>com.puppycrawl.tools</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>8.11</version>
+                        <version>8.18</version>
                     </dependency>
                 </dependencies>
             </plugin>

diff --git a/src/tools/native-client/pom.xml b/src/tools/native-client/pom.xml
@@ -138,7 +138,7 @@
                     <dependency>
                         <groupId>com.puppycrawl.tools</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>8.11</version>
+                        <version>8.18</version>
                     </dependency>
                 </dependencies>
             </plugin>

diff --git a/stylecheck/nebula_java_style_checks.xml b/stylecheck/nebula_java_style_checks.xml
@@ -220,27 +220,6 @@
         </module>
         <module name="NonEmptyAtclauseDescription"/>
         <module name="JavadocTagContinuationIndentation"/>
-        <!--
-	<module name="SummaryJavadoc">
-            <property name="forbiddenSummaryFragments"
-             value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/>
-        </module>
-        <module name="JavadocParagraph"/>
-        <module name="AtclauseOrder">
-            <property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
-            <property name="target"
-             value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
-        </module>
-        <module name="JavadocMethod">
-            <property name="scope" value="public"/>
-            <property name="allowMissingParamTags" value="true"/>
-            <property name="allowMissingThrowsTags" value="true"/>
-            <property name="allowMissingReturnTag" value="true"/>
-            <property name="minLineCount" value="2"/>
-            <property name="allowedAnnotations" value="Override, Test"/>
-            <property name="allowThrowsTagsForSubclasses" value="true"/>
-        </module>
-	-->
         <module name="MethodName">
             <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
             <message key="name.invalidPattern"