fix crash when drop space (#3185)

vesoft-inc · Oct 22, 2021 · b8dc6ac · b8dc6ac
1 parent db6da98
commit b8dc6ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/kvstore/RocksEngine.cpp b/src/kvstore/RocksEngine.cpp
@@ -124,8 +124,8 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
   }
   CHECK(status.ok()) << status.ToString();
   db_.reset(db);
-  partsNum_ = allParts().size();
   extractorLen_ = sizeof(PartitionID) + vIdLen;
+  partsNum_ = allParts().size();
   LOG(INFO) << "open rocksdb on " << path;
 
   backup();

diff --git a/src/kvstore/test/RocksEngineTest.cpp b/src/kvstore/test/RocksEngineTest.cpp
@@ -734,6 +734,8 @@ TEST(RebuildPrefixBloomFilter, RebuildPrefixBloomFilter) {
       EXPECT_EQ("123", value);
     };
 
+    auto checkSystemPart = [&]() { EXPECT_EQ(10, engine->allParts().size()); };
+
     checkVertexPrefix(1, "1");
     checkVertexPrefix(1, "2");
     checkVertexPrefix(2, "3");
@@ -748,11 +750,16 @@ TEST(RebuildPrefixBloomFilter, RebuildPrefixBloomFilter) {
     checkEdgePartPrefix(2);
     checkRangeWithPartPrefix(1);
     checkRangeWithPartPrefix(2);
+    checkSystemPart();
     checkSystemCommit(1);
     checkSystemCommit(2);
   };
 
   auto writeData = [&engine] {
+    for (PartitionID partId = 1; partId <= 10; partId++) {
+      engine->addPart(partId);
+    }
+
     LOG(INFO) << "Write some data";
     std::vector<KV> data;
     for (TagID tagId = 0; tagId < 10; tagId++) {