Skip to content

Commit

Permalink
second round revision
Browse files Browse the repository at this point in the history
  • Loading branch information
JackChuengQAQ committed Oct 28, 2024
1 parent 49ca93a commit 83fb894
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 12 deletions.
2 changes: 1 addition & 1 deletion src/graph/executor/mutate/UpdateExecutor.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2024 vesoft inc. All rights reserved.
// Copyright (c) 2020 vesoft inc. All rights reserved.
//
// This source code is licensed under Apache 2.0 License.

Expand Down
1 change: 0 additions & 1 deletion src/parser/MutateSentences.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ std::string UpdateVertexSentence::toString() const {
} else {
buf += vertices_->toString();
}
buf += vid_->toString();
buf += " SET ";
buf += updateList_->toString();
if (whenClause_ != nullptr) {
Expand Down
2 changes: 0 additions & 2 deletions src/parser/parser.yy
Original file line number Diff line number Diff line change
Expand Up @@ -3966,8 +3966,6 @@ query_unique_identifier
mutate_sentence
: insert_vertex_sentence { $$ = $1; }
| insert_edge_sentence { $$ = $1; }
| update_vertex_sentence { $$ = $1; }
| update_edge_sentence { $$ = $1; }
| download_sentence { $$ = $1; }
| ingest_sentence { $$ = $1; }
| admin_job_sentence { $$ = $1; }
Expand Down
8 changes: 4 additions & 4 deletions tests/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,21 +44,21 @@ test_j_sa = $(test_without_skip_sa) -n$(J)


install-deps:
pip3 install -Ur $(CURR_DIR)/requirements.txt -i $(PYPI_MIRROR)
pip3 install --user -Ur $(CURR_DIR)/requirements.txt -i $(PYPI_MIRROR)

install-nebula-py: install-deps
git clone --branch release-3.5 https://github.com/vesoft-inc/nebula-python $(CURR_DIR)/nebula-python
cd $(CURR_DIR)/nebula-python \
&& pip3 install . -i $(PYPI_MIRROR) --upgrade
&& pip3 install --user . -i $(PYPI_MIRROR) --upgrade
rm -rf $(CURR_DIR)/nebula-python

gherkin-fmt: install-deps
@if [ $(PY_VERSION) -lt 7 ]; then echo 'Python version must >= 3.7'; exit 1; fi
pip3 install poetry
pip3 install --user poetry
git clone --branch master https://github.com/OneContainer/reformat-gherkin $(CURR_DIR)/reformat-gherkin
cd $(CURR_DIR)/reformat-gherkin && python3 -m poetry build
pip3 uninstall -y reformat-gherkin
pip3 install $(CURR_DIR)/reformat-gherkin/dist/reformat_gherkin*.whl
pip3 install --user $(CURR_DIR)/reformat-gherkin/dist/reformat_gherkin*.whl
rm -rf $(CURR_DIR)/reformat-gherkin

init: clean install-nebula-py
Expand Down
1 change: 0 additions & 1 deletion tests/tck/features/lookup/LookUpUpdate.feature
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Copyright (c) 2024 vesoft inc. All rights reserved.
#
# This source code is licensed under Apache 2.0 License.
@lookup_update
Feature: lookup and update

Background:
Expand Down
1 change: 0 additions & 1 deletion tests/tck/features/update/MultiUpdate.feature
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Copyright (c) 2024 vesoft inc. All rights reserved.
#
# This source code is licensed under Apache 2.0 License.
@multi_update
Feature: Multi Update string vid of vertex and edge

Background: Prepare space
Expand Down
1 change: 0 additions & 1 deletion tests/tck/features/update/Update.IntVid.feature
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Copyright (c) 2020 vesoft inc. All rights reserved.
#
# This source code is licensed under Apache 2.0 License.
@update
Feature: Update int vid of vertex and edge

Scenario: update and upsert test
Expand Down
1 change: 0 additions & 1 deletion tests/tck/features/update/Update.feature
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Copyright (c) 2020 vesoft inc. All rights reserved.
#
# This source code is licensed under Apache 2.0 License.
@update
Feature: Update string vid of vertex and edge

Background: Prepare space
Expand Down

0 comments on commit 83fb894

Please sign in to comment.