fix ut and minor changes

vesoft-inc · May 30, 2019 · 3c72ef0 · 3c72ef0
1 parent 74061c8
commit 3c72ef0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/graph/test/SchemaTest.cpp b/src/graph/test/SchemaTest.cpp
@@ -42,9 +42,9 @@ TEST_F(SchemaTest, metaCommunication) {
         cpp2::ExecutionResponse resp;
         std::string query = "SHOW HOSTS";
         client->execute(query, resp);
-        std::vector<uniform_tuple_t<std::string, 2>> expected{
-            {"127.0.0.1", "1000"},
-            {"127.0.0.1", "1100"},
+        std::vector<uniform_tuple_t<std::string, 3>> expected{
+            {"127.0.0.1", "1000", "online"},
+            {"127.0.0.1", "1100", "online"},
         };
         ASSERT_TRUE(verifyResult(resp, expected));
     }

diff --git a/src/meta/processors/BaseProcessor.h b/src/meta/processors/BaseProcessor.h
@@ -171,7 +171,7 @@ class BaseProcessor {
     StatusOr<std::vector<nebula::cpp2::HostAddr>> allHosts();
 
     /**
-     * Get all hosts
+     * Get all hosts with online/offline status.
      * */
     StatusOr<std::vector<cpp2::HostItem>> allHostsWithStatus();
 

diff --git a/src/meta/test/HBProcessorTest.cpp b/src/meta/test/HBProcessorTest.cpp
@@ -25,6 +25,8 @@ using apache::thrift::FragileConstructor::FRAGILE;
 TEST(HBProcessorTest, HBTest) {
     fs::TempDir rootPath("/tmp/HBTest.XXXXXX");
     std::unique_ptr<kvstore::KVStore> kv(TestUtils::initKV(rootPath.path()));
+    FLAGS_expired_hosts_check_interval_sec = 1;
+    FLAGS_expired_threshold_sec = 1;
     {
         std::vector<nebula::cpp2::HostAddr> thriftHosts;
         for (auto i = 0; i < 10; i++) {
@@ -51,8 +53,6 @@ TEST(HBProcessorTest, HBTest) {
         }
     }
     {
-        FLAGS_expired_hosts_check_interval_sec = 1;
-        FLAGS_expired_threshold_sec = 1;
         for (auto i = 0; i < 5; i++) {
             cpp2::HBReq req;
             nebula::cpp2::HostAddr thriftHost(FRAGILE, i, i);