set rocksdb_disable_wal to false by default (#2236)

Co-authored-by: dangleptr <[email protected]>
vesoft-inc · Jul 17, 2020 · 26aac4b · 26aac4b
1 parent eedd52b
commit 26aac4b
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 9 deletions.
diff --git a/etc/nebula-metad.conf.production b/etc/nebula-metad.conf.production
@@ -35,5 +35,4 @@
 --data_path=data/meta
 
 ############## rocksdb Options ##############
---rocksdb_disable_wal=false
 --rocksdb_wal_sync=true
diff --git a/etc/nebula-storaged.conf.default b/etc/nebula-storaged.conf.default
@@ -65,11 +65,7 @@
 # In order to disable compression for level 0/1, set it to "no:no"
 --rocksdb_compression_per_level=
 
---rocksdb_disable_wal=true
-
 ############## rocksdb Options ##############
---rocksdb_disable_wal=true
-
 # rocksdb DBOptions in json, each name and value of option is a string, given as "option_name":"option_value" separated by comma
 --rocksdb_db_options={"max_subcompactions":"1","max_background_jobs":"1"}
 # rocksdb ColumnFamilyOptions in json, each name and value of option is string, given as "option_name":"option_value" separated by comma

diff --git a/etc/nebula-storaged.conf.production b/etc/nebula-storaged.conf.production
@@ -66,8 +66,6 @@
 # In order to disable compression for level 0/1, set it to "no:no"
 --rocksdb_compression_per_level=
 
---rocksdb_disable_wal=true
-
 # rocksdb DBOptions in json, each name and value of option is a string, given as "option_name":"option_value" separated by comma
 --rocksdb_db_options={"max_subcompactions":"4","max_background_jobs":"4"}
 # rocksdb ColumnFamilyOptions in json, each name and value of option is string, given as "option_name":"option_value" separated by comma

diff --git a/kubernetes/helm/templates/configmap.yaml b/kubernetes/helm/templates/configmap.yaml
@@ -156,7 +156,6 @@ data:
     --engine_type=rocksdb
 
     ############## rocksdb Options ##############
-    --rocksdb_disable_wal=true
     # rocksdb DBOptions in json, each name and value of option is a string, given as "option_name":"option_value" separated by comma
     --rocksdb_db_options={}
     # rocksdb ColumnFamilyOptions in json, each name and value of option is string, given as "option_name":"option_value" separated by comma

diff --git a/src/kvstore/RocksEngineConfig.cpp b/src/kvstore/RocksEngineConfig.cpp
@@ -17,7 +17,7 @@
 
 // [WAL]
 DEFINE_bool(rocksdb_disable_wal,
-            true,
+            false,
             "Whether to disable the WAL in rocksdb");
 
 DEFINE_bool(rocksdb_wal_sync,