fix unit test error

vesoft-inc · Jan 13, 2022 · 23832d8 · 23832d8
1 parent afa027c
commit 23832d8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/graph/util/ExpressionUtils.cpp b/src/graph/util/ExpressionUtils.cpp
@@ -588,7 +588,7 @@ StatusOr<Expression *> ExpressionUtils::filterTransform(const Expression *filter
   }
 
   // Rewrite relational expression
-  auto rewrittenExpr = rewriteRelExpr(newFilter);
+  auto rewrittenExpr = rewriteRelExpr(newFilter->clone());
 
   // Fold constant expression
   auto constantFoldRes = foldConstantExpr(rewrittenExpr);

diff --git a/src/graph/visitor/test/FilterTransformTest.cpp b/src/graph/visitor/test/FilterTransformTest.cpp
@@ -32,15 +32,17 @@ TEST_F(FilterTransformTest, TestCalculationOverflow) {
     auto res = ExpressionUtils::filterTransform(expr);
     ASSERT(res.ok());
     auto expected = expr;
-    ASSERT_EQ(res.value(), expected) << res.value() << " vs. " << expected->toString();
+    ASSERT_EQ(res.value()->toString(), expected->toString())
+        << res.value()->toString() << " vs. " << expected->toString();
   }
   // (v.age + 1 < -9223372036854775808)  =>  unchanged
   {
     auto expr = ltExpr(addExpr(laExpr("v", "age"), constantExpr(1)), constantExpr(INT64_MIN));
     auto res = ExpressionUtils::filterTransform(expr);
     ASSERT(res.ok());
     auto expected = expr;
-    ASSERT_EQ(res.value(), expected) << res.value() << " vs. " << expected->toString();
+    ASSERT_EQ(res.value()->toString(), expected->toString())
+        << res.value()->toString() << " vs. " << expected->toString();
   }
   // (v.age - 1 < 9223372036854775807 + 1)  =>  overflow
   {
@@ -71,7 +73,8 @@ TEST_F(FilterTransformTest, TestCalculationOverflow) {
     auto res = ExpressionUtils::filterTransform(expr);
     ASSERT(res.ok());
     auto expected = expr;
-    ASSERT_EQ(res.value(), expected) << res.value()->toString() << " vs. " << expected->toString();
+    ASSERT_EQ(res.value()->toString(), expected->toString())
+        << res.value()->toString() << " vs. " << expected->toString();
   }
   // !!!(v.age + 1 < -9223372036854775808)  =>  unchanged
   {
@@ -80,7 +83,8 @@ TEST_F(FilterTransformTest, TestCalculationOverflow) {
     auto res = ExpressionUtils::filterTransform(expr);
     ASSERT(res.ok());
     auto expected = expr;
-    ASSERT_EQ(res.value(), expected) << res.value()->toString() << " vs. " << expected->toString();
+    ASSERT_EQ(res.value()->toString(), expected->toString())
+        << res.value()->toString() << " vs. " << expected->toString();
   }
 }