Fix ExtractFilterExprVisitor.

vesoft-inc · Mar 24, 2023 · 1619a8a · 1619a8a
1 parent 2f5a57d
commit 1619a8a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/graph/visitor/ExtractFilterExprVisitor.cpp b/src/graph/visitor/ExtractFilterExprVisitor.cpp
@@ -240,12 +240,26 @@ void ExtractFilterExprVisitor::ExtractRemainExpr(LogicalExpression *expr,
     extractedExpr_ = operands[0];
   }
 
+  LogicalExpression *remainedExpr = nullptr;
   if (remainedOperands.size() > 1) {
-    auto remainedExpr = LogicalExpression::makeAnd(pool_);
+    remainedExpr = LogicalExpression::makeAnd(pool_);
     remainedExpr->setOperands(std::move(remainedOperands));
-    remainedExpr_ = std::move(remainedExpr);
   } else {
-    remainedExpr_ = std::move(remainedOperands[0]);
+    remainedExpr = static_cast<LogicalExpression *>(std::move(remainedOperands[0]));
+  }
+  if (remainedExpr_ != nullptr) {
+    if (remainedExprFromAnd_) {
+      auto mergeExpr = LogicalExpression::makeAnd(pool_, remainedExpr_, std::move(remainedExpr));
+      remainedExpr_ = std::move(mergeExpr);
+      remainedExprFromAnd_ = true;
+    } else {
+      auto mergeExpr = LogicalExpression::makeOr(pool_, remainedExpr_, std::move(remainedExpr));
+      remainedExpr_ = std::move(mergeExpr);
+      remainedExprFromAnd_ = true;
+    }
+  } else {
+    remainedExpr_ = std::move(remainedExpr);
+    remainedExprFromAnd_ = true;
   }
 }
 
@@ -375,6 +389,7 @@ void ExtractFilterExprVisitor::visit(LogicalExpression *expr) {
       DCHECK_EQ(expr->kind(), Expression::Kind::kLogicalAnd);
       DCHECK_EQ(expr->operands().size(), 2);
       remainedExpr_ = expr->operands()[1]->clone();
+      remainedExprFromAnd_ = false;
       expr->operands().pop_back();
     }
   } else {

diff --git a/src/graph/visitor/ExtractFilterExprVisitor.h b/src/graph/visitor/ExtractFilterExprVisitor.h
@@ -94,6 +94,7 @@ class ExtractFilterExprVisitor final : public ExprVisitorImpl {
   bool hasSplit{false};
   bool splitForbidden{false};
   Expression *remainedExpr_{nullptr};
+  bool remainedExprFromAnd_{false};
   Expression *extractedExpr_{nullptr};
   PushType pushType_{PushType::kGetNeighbors};
   std::vector<std::string> colNames_;