address comment

vesoft-inc · Feb 15, 2022 · 0b437ff · 0b437ff
1 parent 2645327
commit 0b437ff
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/graph/executor/algo/SubgraphExecutor.cpp b/src/graph/executor/algo/SubgraphExecutor.cpp
@@ -42,7 +42,8 @@ folly::Future<Status> SubgraphExecutor::execute() {
   auto& biDirectEdgeTypes = subgraph->biDirectEdgeTypes();
   while (iter->valid()) {
     const auto& dst = iter->getEdgeProp("*", nebula::kDst);
-    if (historyVids_.find(dst) != historyVids_.end()) {
+    auto findIter = historyVids_.find(dst);
+    if (findIter != historyVids_.end()) {
       if (biDirectEdgeTypes.empty()) {
         iter->next();
       } else {
@@ -53,7 +54,7 @@ folly::Future<Status> SubgraphExecutor::execute() {
         }
         auto type = typeVal.getInt();
         if (biDirectEdgeTypes.find(type) != biDirectEdgeTypes.end()) {
-          if (type < 0 || historyVids_[dst] + 2 == currentStep) {
+          if (type < 0 || findIter->second + 2 == currentStep) {
             iter->erase();
           } else {
             iter->next();

diff --git a/src/graph/executor/query/DataCollectExecutor.cpp b/src/graph/executor/query/DataCollectExecutor.cpp
@@ -86,6 +86,9 @@ Status DataCollectExecutor::collectSubgraph(const std::vector<std::string>& vars
         }
         edges.emplace_back(std::move(edge));
       }
+      if (vertices.empty() && edges.empty()) {
+        break;
+      }
       ds.rows.emplace_back(Row({std::move(vertices), std::move(edges)}));
     }
   }

diff --git a/tests/tck/features/subgraph/subgraph.feature b/tests/tck/features/subgraph/subgraph.feature
@@ -1,7 +1,6 @@
 # Copyright (c) 2021 vesoft inc. All rights reserved.
 #
 # This source code is licensed under Apache 2.0 License.
-@jmq
 Feature: subgraph
 
   Background:
@@ -326,7 +325,6 @@ Feature: subgraph
       | <[vertex2]>      | <[edge2]>     |
       | <[vertex3]>      | <[edge3]>     |
 
-  @jmm
   Scenario: two steps in and out edge
     When executing query:
       """
@@ -1059,4 +1057,3 @@ Feature: subgraph
     Then the result should be, in any order, with relax comparison:
       | nodes     | relationships |
       | [("Tom")] | []            |
-      | []        | []            |
-Original file line number
+Diff line change
@@ Expand Up @@
             }
             edges.emplace_back(std::move(edge));
           }
+          if (vertices.empty() && edges.empty()) {
+            break;
+          }
           ds.rows.emplace_back(Row({std::move(vertices), std::move(edges)}));
         }
       }
@@ Expand Down @@