Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 24.04 support & upgrade arrow 18 #151

Merged
merged 18 commits into from
Nov 19, 2024

Conversation

Shinji-IkariG
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

codesigner
codesigner previously approved these changes Nov 7, 2024
codesigner
codesigner previously approved these changes Nov 7, 2024
czpmango
czpmango previously approved these changes Nov 7, 2024
@czpmango czpmango marked this pull request as draft November 7, 2024 11:02
@Shinji-IkariG Shinji-IkariG marked this pull request as ready for review November 11, 2024 02:18
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. workflow compiler
  2. libxml2
  3. optimization option

@Shinji-IkariG Shinji-IkariG dismissed stale reviews from czpmango and codesigner via 15b0b19 November 11, 2024 02:42
@Shinji-IkariG Shinji-IkariG marked this pull request as draft November 11, 2024 06:31
@Shinji-IkariG
Copy link
Contributor Author

  1. workflow compiler
  2. libxml2
  3. optimization option

libxml2 linked by libarrow.so it will add in this pr.

@Shinji-IkariG Shinji-IkariG marked this pull request as ready for review November 15, 2024 03:27
@Shinji-IkariG
Copy link
Contributor Author

  1. workflow compiler
  2. libxml2
  3. optimization option

compiler version fixed and change to 9.5.0
libxml2 has been added
faiss O1 option has been remove,it can be build with GCC >= 9.4.0

.github/workflows/build.yml Outdated Show resolved Hide resolved
project/externals/libxml2.cmake Outdated Show resolved Hide resolved
project/externals/libxml2.cmake Outdated Show resolved Hide resolved
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dutor dutor merged commit 0d43d91 into vesoft-inc:master Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants