Skip to content

Commit

Permalink
Replace the _OPENSSL_LIBDIR with OPENSSL_ROOT_DIR (#130)
Browse files Browse the repository at this point in the history
* Update OPENSSL root directory cmake args

* Remove the SOURCE_PREFIX variable

* Fix exec linker flags of fbthrift
  • Loading branch information
yixinglu authored Feb 4, 2024
1 parent 4abe695 commit 90b9672
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ echo "Starting building third-party libraries"

$cmake_cmd -DDOWNLOAD_DIR=$download_dir \
-DCMAKE_INSTALL_PREFIX=$install_dir \
-DSOURCE_PREFIX=$source_dir \
${C_COMPILER_ARG} ${CXX_COMPILER_ARG} \
${DISABLE_CXX11_ABI} \
$source_dir |& tee $logfile
Expand Down
2 changes: 1 addition & 1 deletion project/externals/fbthrift.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ExternalProject_Add(
-DCMAKE_BUILD_TYPE=Release
-DBoost_NO_BOOST_CMAKE=ON
-Denable_tests=OFF
-D_OPENSSL_LIBDIR=${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}
-DOPENSSL_ROOT_DIR=${CMAKE_INSTALL_PREFIX}
BUILD_COMMAND make -s -j${BUILDING_JOBS_NUM}
BUILD_IN_SOURCE 1
INSTALL_COMMAND make -s -j${BUILDING_JOBS_NUM} install
Expand Down
2 changes: 1 addition & 1 deletion project/externals/fizz.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ExternalProject_Add(
-DBoost_NO_BOOST_CMAKE=ON
-DBUILD_EXAMPLES=OFF
-DCMAKE_BUILD_TYPE=Release
-D_OPENSSL_LIBDIR=${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}
-DOPENSSL_ROOT_DIR=${CMAKE_INSTALL_PREFIX}
BUILD_COMMAND make -s -j${BUILDING_JOBS_NUM}
BUILD_IN_SOURCE 1
INSTALL_COMMAND make -s -j${BUILDING_JOBS_NUM} install
Expand Down
2 changes: 1 addition & 1 deletion project/externals/wangle.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ ExternalProject_Add_Step(${name} mannual-configure
-DCMAKE_BUILD_TYPE=Release
-DBUILD_TESTS=OFF
-DCMAKE_EXE_LINKER_FLAGS=-latomic
-D_OPENSSL_LIBDIR=${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}
-DOPENSSL_ROOT_DIR=${CMAKE_INSTALL_PREFIX}
.
WORKING_DIRECTORY <SOURCE_DIR>/wangle
)
Expand Down

0 comments on commit 90b9672

Please sign in to comment.